[GitHub] andrzej-kaczmarek commented on a change in pull request #1536: hw/bus: Multiple fixes for bus driver (and related code)

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #1536: hw/bus: Multiple fixes for bus driver (and related code)
URL: https://github.com/apache/mynewt-core/pull/1536#discussion_r237658863
 
 

 ##########
 File path: hw/bus/src/bus.c
 ##########
 @@ -285,8 +292,18 @@ bus_node_unlock(struct os_dev *node)
     return 0;
 }
 
+os_time_t
+bus_node_get_lock_timeout(struct os_dev *node)
 
 Review comment:
   my idea here is to let user specify per-node lock timeout in node configuration and getter is to return effective lock timeout for a node, i.e. either default one (if not configured) or the one configured for a node. I think there's no reason for user to reconfigure lock timeout in runtime - by default all nodes can be locked with the same /reasonable/ timeout but perhaps some nodes should be accessed with e.g. very short lock timeout so they either can be read instantly or not at all and for this it's enough to configure this on build time. but there may be some actual scenarios which require different behaviour so comments are always welcome :)
   
   I'll include implementation of this in next series of commits I'm working on currently.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services