[GitHub] [ozone] umamaheswararao commented on pull request #2444: HDDS-5364. EC: Adopt EC related utility from Hadoop source repository

[GitBox <gi...@apache.org>]

umamaheswararao commented on pull request #2444:
URL: https://github.com/apache/ozone/pull/2444#issuecomment-914428347


   > Thanks the answer @umamaheswararao
   > 
   > However, I am not sure how is it possible. Just copying the code wouldn't compile. We have different dependency structure, package names and configuration objects.
   > 
   > But here I didn't change any logic, just copied the code and updated the used configuration interfaces. So technicaly this patch is the copy without any significant change.
   
   I agree there is no logic change. Only worry is about the patch size and it's easy to miss things. For example, above conflict changes are not necessarily in this patch I guess. They are about using the new EcReplicationConfig with codec option. Currently they are already have default values and we can easily use this patch ECReplicationConfig in next patch. That way we can reduce modifications in this patch. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org