[GitHub] [apisix-dashboard] qsliu2017 commented on a change in pull request #2133: ci: optimize build rpm workflow with apisix-build-tools v2.2.0

[GitBox <gi...@apache.org>]

qsliu2017 commented on a change in pull request #2133:
URL: https://github.com/apache/apisix-dashboard/pull/2133#discussion_r705868397



##########
File path: .github/workflows/auto-build-rpm.yml
##########
@@ -29,6 +29,16 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v2
 
+      - uses: docker/setup-buildx-action@v1
+
+      - uses: actions/cache@v2
+        with:
+          path: /tmp/.buildx-cache
+          key: ${{ runner.os }}-buildx-apisixdashboard-${{ github.sha }}
+          restore-keys: |
+            ${{ runner.os }}-buildx-apisixdashboard-
+            ${{ runner.os }}-buildx-

Review comment:
       @starsz we need restore keys, or every new commit will cache miss. The caches are docker layers, and docker uses it only for layers that are exactly the same. so that's ok to use the old cache




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org