You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/18 12:57:08 UTC
[GitHub] [superset] stephenLYZ opened a new pull request #14221: fix(explore): fix clearing select data causes popover dismiss
stephenLYZ opened a new pull request #14221:
URL: https://github.com/apache/superset/pull/14221
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The clear icon of react-select will disappear after clicking, and the popover component of Antd will capture the parent component (here is document.body) under the mousedown event, this event will determine whether the current target exists under the parent component, if it does not exist, the popover will be closed, and at this time the clear icon no longer exists.
All select components which set to `clearable` under popover will have the same problem.
So here I passed the `actionMeta` property, if it is a clear event, the popover will not be closed
.### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
#### Before

#### After

### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Fixes #12475
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #14221: fix(explore): fix clearing select data causes popover dismiss
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14221:
URL: https://github.com/apache/superset/pull/14221#issuecomment-845368711
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #14221: fix(explore): fix clearing select data causes popover dismiss
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #14221:
URL: https://github.com/apache/superset/pull/14221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #14221: fix(explore): fix clearing select data causes popover dismiss
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14221:
URL: https://github.com/apache/superset/pull/14221#issuecomment-842694584
@pkdotson Ephemeral environment spinning up at http://34.220.174.219:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on pull request #14221: fix(explore): fix clearing select data causes popover dismiss
Posted by GitBox <gi...@apache.org>.
pkdotson commented on pull request #14221:
URL: https://github.com/apache/superset/pull/14221#issuecomment-842693784
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org