You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/12/02 06:08:39 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request #13897: Add schedule basic modules and schedule-core module initial commit

sandynz opened a new pull request #13897:
URL: https://github.com/apache/shardingsphere/pull/13897


   Fixes #13875 part 1.
   
   Changes proposed in this pull request:
   - Add schedule basic modules
   - Move ScalingExecutor to schedule-core module, rename to LifecycleExecutor
   
   Next will be some refactoring of seprating sharding from scaling, then move scaling-core common to migration-common.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #13897: Add schedule basic modules and schedule-core module initial commit

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #13897:
URL: https://github.com/apache/shardingsphere/pull/13897#discussion_r760798792



##########
File path: shardingsphere-kernel/shardingsphere-schedule/shardingsphere-cdc/pom.xml
##########
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <parent>
+        <artifactId>shardingsphere-schedule</artifactId>
+        <groupId>org.apache.shardingsphere</groupId>
+        <version>5.0.1-SNAPSHOT</version>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+    <artifactId>shardingsphere-cdc</artifactId>
+    <packaging>pom</packaging>
+    <name>${project.artifactId}</name>
+    
+    <modules>
+        <module>shardingsphere-cdc-core</module>
+        <module>shardingsphere-cdc-dialect</module>
+    </modules>
+</project>

Review comment:
       @sandynz Please add new line at the end of file.

##########
File path: shardingsphere-kernel/shardingsphere-schedule/shardingsphere-schedule-core/src/main/java/org/apache/shardingsphere/schedule/core/executor/LifecycleExecutor.java
##########
@@ -15,12 +15,12 @@
  * limitations under the License.
  */
 
-package org.apache.shardingsphere.scaling.core.executor;
+package org.apache.shardingsphere.schedule.core.executor;
 
 /**
- * Scaling executor.
+ * lifecycle executor.

Review comment:
       @sandynz The first letter in javadoc needs to be capitalized.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] strongduanmu merged pull request #13897: Add schedule basic modules and schedule-core module initial commit

Posted by GitBox <gi...@apache.org>.
strongduanmu merged pull request #13897:
URL: https://github.com/apache/shardingsphere/pull/13897


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org