You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2024/07/16 16:06:02 UTC
[PR] [CELEBORN-1318][FOLLOWUP] Upload the celeborn-common to nexus staging for http authentication extensions [celeborn]
turboFei opened a new pull request, #2632:
URL: https://github.com/apache/celeborn/pull/2632
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Since https://github.com/apache/celeborn/pull/2440, http authentication is supported.
In this pr, we deploy the celeborn-common so that users can leverage the SDK for http authentication extensions.
### Why are the changes needed?
For http authentication extensions in users end.
### Does this PR introduce _any_ user-facing change?
No, just deploy the celeborn-common.
### How was this patch tested?
Run the command locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1318][FOLLOWUP] Upload the celeborn-common to nexus staging for http authentication extensions [celeborn]
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #2632:
URL: https://github.com/apache/celeborn/pull/2632#issuecomment-2248281911
+1 to an spi module.
Ideally, keep dependencies for that module minimal as well (so that clients and server side can depend on the same)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1318][FOLLOWUP] Upload the celeborn-common to nexus staging for http authentication extensions [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2632:
URL: https://github.com/apache/celeborn/pull/2632#issuecomment-2248643346
raised patch: https://github.com/apache/celeborn/pull/2644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1318][FOLLOWUP] Upload the celeborn-common to nexus staging for http authentication extensions [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #2632: [CELEBORN-1318][FOLLOWUP] Upload the celeborn-common to nexus staging for http authentication extensions
URL: https://github.com/apache/celeborn/pull/2632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1318][FOLLOWUP] Upload the celeborn-common to nexus staging for http authentication extensions [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2632:
URL: https://github.com/apache/celeborn/pull/2632#issuecomment-2244115301
thanks, merged to main/0.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1318][FOLLOWUP] Upload the celeborn-common to nexus staging for http authentication extensions [celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #2632:
URL: https://github.com/apache/celeborn/pull/2632#issuecomment-2247132115
we are continuously adding user extendable interface in different modules, this will eventually result in to publish every modules, I'm wondering if we can create a dedicated module `celeborn-spi` to centralize all extendable interfaces? aslo every interfaces should be annoted with `@since`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1318][FOLLOWUP] Upload the celeborn-common to nexus staging for http authentication extensions [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2632:
URL: https://github.com/apache/celeborn/pull/2632#issuecomment-2248292341
ok, thanks for the comments， will address it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org