[GitHub] flink issue #2925: [FLINK-4574] [kinesis] Strengthen fetch interval implemen...

[tony810430 <gi...@git.apache.org>]

Github user tony810430 commented on the issue:

    https://github.com/apache/flink/pull/2925
  
    Hi, @tzulitai 
    
    I think there is no better way if trying to use `Timer` to deal with `0` fetch interval. Even though I implement my own `Timer` scheduler, it just move the `runForever` inside from `ShardConsumerTask`. Because fetch interval is `0`, there is no way to get the next expected execution time and the solution would be running the function forever.
    
    I think a better solution is defined non-positive fetch interval differs from positive fetch interval and would be executed in another way in the document. The implementation will be two parts: the original way remains the same without `runForever` in `ShardConsumerFetcherTask` and the other is for non-positive fetch interval implemented by using a Thread running `ShardConsumerFetcherTask::run()` forever.
    
    It is more reasonable for me to distinguish these two configuration and implement them by using two ways in `ShardConsumer::run()`. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---