You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/11/16 17:47:21 UTC
[GitHub] [lucene] rmuir opened a new pull request, #11944: enable errorprone for github check action
rmuir opened a new pull request, #11944:
URL: https://github.com/apache/lucene/pull/11944
The idea is to fail faster, prevent new violations from failing nightly builds. If it becomes a hindrance to contributions or an annoyance, we can disable it.
Closes #11943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11944: enable errorprone for github check action
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317529801
If it works, build should fail and look like this:
```
> Task :lucene:core:compileTestJava FAILED
/home/rmuir/workspace/lucene/lucene/core/src/test/org/apache/lucene/TestDemo.java:76: warning: [ConstantOverflow] Compile-time constant expression overflows
long x = Integer.MAX_VALUE * Integer.MAX_VALUE;
^
(see https://errorprone.info/bugpattern/ConstantOverflow)
error: warnings found and -Werror specified
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error
1 warning
FAILURE: Build failed with an exception.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11944: enable errorprone for github check action
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317507423
Well, it was definitely slower before the patch ()?
https://github.com/apache/lucene/actions/runs/3473485571/jobs/5805548845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11944: enable errorprone for github check action
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317510122
> hmm... so did it actually run? :)
You could try to revert the commit with offending code - then we'd see. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11944: enable errorprone for github check action
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317507534
hmm... so did it actually run? :)
fwiw, my biggest concern for this is annoying contributors. if they do the right thing and `gradle check` fails, then make a contribution and the build fails here, it could bother them. Especially if they have to play whack-a-mole because error-prone feeds them one violation at a time :(
At the same time, we don't have a lot of crazy error-prone checks turned on... they are selective... so hopefully it would be more of a rare event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] risdenk commented on pull request #11944: enable errorprone for github check action
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317463797
Looking at the last main github actions run: https://github.com/apache/lucene/actions/runs/3481009561/jobs/5821544088 The gradle check without tests was `6m 32s`. The same step for this github actions run: https://github.com/apache/lucene/actions/runs/3481792417/jobs/5823331065 was `6m 37s`
So 5s added from what I can tell now. Based on the compile times doesn't look like the 5 seconds was from compile either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11944: enable errorprone for github check action
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317515764
i will add a violation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11944: enable errorprone for github check action
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317535353
It worked... even for the `gradle test` task which didn't turn it on. So now i'm wondering if it has been enabled here all along because of `isCIBuild` which has a "CI-detector" that looks at env vars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11944: enable errorprone for github check action
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317542732
yeah, nothing to do here apparently. errorprone is already on via magical CI detection: `isCIBuild = System.getenv().keySet().find { it ==~ /(?i)((JENKINS|HUDSON)(_\w+)?|CI)/ } != null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir closed pull request #11944: enable errorprone for github check action
Posted by GitBox <gi...@apache.org>.
rmuir closed pull request #11944: enable errorprone for github check action
URL: https://github.com/apache/lucene/pull/11944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org