You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/19 07:25:20 UTC

[GitHub] [doris] morrySnow opened a new pull request, #16092: [fix](planner) create view generate wrong sql when sql contains multi count distinct

morrySnow opened a new pull request, #16092:
URL: https://github.com/apache/doris/pull/16092

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   If sql in create view has more than one count distinct, and write column name explicitly.
   We will generate sql contains function multi_count_distinct.
   It cannot be analyzed and all query containing this view will fail.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #16092: [fix](planner) create view generate wrong sql when sql contains multi count distinct

Posted by github-actions.
github-actions[bot] commented on PR #16092:
URL: https://github.com/apache/doris/pull/16092#issuecomment-1410168603

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman merged pull request #16092: [fix](planner) create view generate wrong sql when sql contains multi count distinct

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #16092:
URL: https://github.com/apache/doris/pull/16092


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #16092: [fix](planner) create view generate wrong sql when sql contains multi count distinct

Posted by github-actions.
github-actions[bot] commented on PR #16092:
URL: https://github.com/apache/doris/pull/16092#issuecomment-1410168525

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #16092: [fix](planner) create view generate wrong sql when sql contains multi count distinct

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #16092:
URL: https://github.com/apache/doris/pull/16092#issuecomment-1396595860

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 33.96 seconds
    load time: 495 seconds
    storage size: 17121921648 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230119081718_clickbench_pr_83978.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org