You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "dbalek (via GitHub)" <gi...@apache.org> on 2024/12/05 14:16:48 UTC

[PR] Test single file should work for test classes which names do not match the corresponding file names. [netbeans]

dbalek opened a new pull request, #8021:
URL: https://github.com/apache/netbeans/pull/8021

   Test single file should work for test classes which names do not match the corresponding file names.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Test single file should work for test classes which names do not match the corresponding file names. [netbeans]

Posted by "dbalek (via GitHub)" <gi...@apache.org>.
dbalek commented on code in PR #8021:
URL: https://github.com/apache/netbeans/pull/8021#discussion_r1871653709


##########
java/gradle.java/nbproject/project.xml:
##########
@@ -158,20 +167,19 @@
                     </run-dependency>
                 </dependency>
                 <dependency>
-                    <code-name-base>org.netbeans.modules.java.api.common</code-name-base>
+                    <code-name-base>org.netbeans.modules.java.source.base</code-name-base>

Review Comment:
   Hope so



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Test single file should work for test classes which names do not match the corresponding file names. [netbeans]

Posted by "dbalek (via GitHub)" <gi...@apache.org>.
dbalek merged PR #8021:
URL: https://github.com/apache/netbeans/pull/8021


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Test single file should work for test classes which names do not match the corresponding file names. [netbeans]

Posted by "dbalek (via GitHub)" <gi...@apache.org>.
dbalek commented on code in PR #8021:
URL: https://github.com/apache/netbeans/pull/8021#discussion_r1871654484


##########
java/java.source.base/apichanges.xml:
##########
@@ -25,6 +25,18 @@
     <apidef name="javasource_base">Java Source API</apidef>
 </apidefs>
 <changes>
+    <change id="SourceUtils.classNameFor">
+        <api name="javasource_base" />
+        <summary>Adding TreeMaker.RawText</summary>

Review Comment:
   Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Test single file should work for test classes which names do not match the corresponding file names. [netbeans]

Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on code in PR #8021:
URL: https://github.com/apache/netbeans/pull/8021#discussion_r1871480808


##########
java/gradle.java/nbproject/project.xml:
##########
@@ -158,20 +167,19 @@
                     </run-dependency>
                 </dependency>
                 <dependency>
-                    <code-name-base>org.netbeans.modules.java.api.common</code-name-base>
+                    <code-name-base>org.netbeans.modules.java.source.base</code-name-base>

Review Comment:
   Just to be sure: is the change in this dependency spec version the only effective change in the file's diff ?



##########
java/java.source.base/apichanges.xml:
##########
@@ -25,6 +25,18 @@
     <apidef name="javasource_base">Java Source API</apidef>
 </apidefs>
 <changes>
+    <change id="SourceUtils.classNameFor">
+        <api name="javasource_base" />
+        <summary>Adding TreeMaker.RawText</summary>

Review Comment:
   Copypaste leftover ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists