You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Samrose-Ahmed (via GitHub)" <gi...@apache.org> on 2023/10/02 06:05:46 UTC

[GitHub] [arrow-datafusion] Samrose-Ahmed commented on pull request #7663: fix: avro_to_arrow: Handle avro nested nullable struct (union)

Samrose-Ahmed commented on PR #7663:
URL: https://github.com/apache/arrow-datafusion/pull/7663#issuecomment-1742440996

   I've updated the PR. 
   
   I've fixed a correctness issue needed for this PR with mapping the Avro and Arrow schema as well, the Avro Record name should not be used in Arrow (the code that was doing `&format!("{}.{}", name.fullname(None), field.name)`, only the field names should be used, the record name is an Avro concept used for schema merging/references. I've added a test for that as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org