You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/20 17:50:53 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11575: [BEAM-9699] Add test verifying we can use ZetaSQL in Python SqlTransform

TheNeuralBit commented on a change in pull request #11575:
URL: https://github.com/apache/beam/pull/11575#discussion_r428198550



##########
File path: sdks/python/apache_beam/transforms/sql.py
##########
@@ -31,8 +31,15 @@
 
 __all__ = ['SqlTransform']
 
+_SQL_PLANNERS = {
+    'zetasql': 'org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner',

Review comment:
       Yeah I think that makes sense. Pushed a commit that moves it into the Java side. The only caveat is I had to move the external transform code out of SqlTransform itself (and into the expansion-service package) so that we can reference ZetaSQL.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org