You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/10/17 21:36:32 UTC
[GitHub] [pinot] walterddr opened a new issue #7591: Ability to accept config override via PinotAdministrator
walterddr opened a new issue #7591:
URL: https://github.com/apache/pinot/issues/7591
Currently there are several config override mechanisms when launching the pinot cluster
1. via [QuickStartRunner](https://github.com/apache/pinot/blob/16e4e3fdfea681be52f5953e3f0f3a343605cc5d/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickstartRunner.java#L83-L85)
2. via individual Command's setConfigOverrides method such as [this one](https://github.com/apache/pinot/blob/16e4e3fdfea681be52f5953e3f0f3a343605cc5d/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServerCommand.java#L119-L122)
3. via config file by passing in `-configFileName` via command line.
this makes it a bit challenging if one wants to launch a Pinot cluster with ability for flexible overrides via command line. --> which is the [documented way](https://docs.pinot.apache.org/basics/getting-started#bootstrapping-a-cluster) to start a cluster.
Therefore, propose to allow variable length commandline arguments of generic key-value overrides such as `-Dkey=value` along with -configFileName arguments. where explicit key-value definition pair overrides any configuration file supplied content.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 closed issue #7591: Ability to accept config override via PinotAdministrator
Posted by GitBox <gi...@apache.org>.
xiangfu0 closed issue #7591:
URL: https://github.com/apache/pinot/issues/7591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 closed issue #7591: Ability to accept config override via PinotAdministrator
Posted by GitBox <gi...@apache.org>.
xiangfu0 closed issue #7591:
URL: https://github.com/apache/pinot/issues/7591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on issue #7591: Ability to accept config override via PinotAdministrator
Posted by GitBox <gi...@apache.org>.
walterddr commented on issue #7591:
URL: https://github.com/apache/pinot/issues/7591#issuecomment-947105453
Looked into the current state of args4j - pinot's commandline parser. it seems like the project hasn't have any new contribution since 2019 and i dont see an easy way to support dynamic parameters.
I was hoping to get some feedback regarding whether it is ok to switch to a more modern CLI parser such as [picocli](https://github.com/remkop/picocli).
I will create a small POC to demonstrate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kkrugler commented on issue #7591: Ability to accept config override via PinotAdministrator
Posted by GitBox <gi...@apache.org>.
kkrugler commented on issue #7591:
URL: https://github.com/apache/pinot/issues/7591#issuecomment-950219629
+1 for switching from args4j to picocli - we've been making that same transition in other projects, for the same reason (lack of activity in args4j project).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 closed issue #7591: Ability to accept config override via PinotAdministrator
Posted by GitBox <gi...@apache.org>.
xiangfu0 closed issue #7591:
URL: https://github.com/apache/pinot/issues/7591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org