You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/26 09:03:37 UTC
[GitHub] [spark] yaooqinn opened a new pull request #27706: [MINOR][BUILD]
Improve readability of the usage of make-distribution.sh
yaooqinn opened a new pull request #27706: [MINOR][BUILD] Improve readability of the usage of make-distribution.sh
URL: https://github.com/apache/spark/pull/27706
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
turn off `x` mode and do not print the command while printing usage of `make-distribution.sh`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
improve dev tools
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
for only developers, clearer hints
#### after
```
./dev/make-distribution.sh --hel
+++ dirname ./dev/make-distribution.sh
++ cd ./dev/..
++ pwd
+ SPARK_HOME=/Users/kentyao/spark
+ DISTDIR=/Users/kentyao/spark/dist
+ MAKE_TGZ=false
+ MAKE_PIP=false
+ MAKE_R=false
+ NAME=none
+ MVN=/Users/kentyao/spark/build/mvn
+ (( 1 ))
+ case $1 in
+ echo 'Error: --hel is not supported'
Error: --hel is not supported
+ exit_with_usage
+ set +x
make-distribution.sh - tool for making binary distributions of Spark
usage:
make-distribution.sh [--name] [--tgz] [--pip] [--r] [--mvn <mvn-command>] <maven build options>
See Spark's "Building Spark" doc for correct Maven options.
```
#### before
```
+++ dirname ./dev/make-distribution.sh
++ cd ./dev/..
++ pwd
+ SPARK_HOME=/Users/kentyao/spark
+ DISTDIR=/Users/kentyao/spark/dist
+ MAKE_TGZ=false
+ MAKE_PIP=false
+ MAKE_R=false
+ NAME=none
+ MVN=/Users/kentyao/spark/build/mvn
+ (( 1 ))
+ case $1 in
+ echo 'Error: --hel is not supported'
Error: --hel is not supported
+ exit_with_usage
+ echo 'make-distribution.sh - tool for making binary distributions of Spark'
make-distribution.sh - tool for making binary distributions of Spark
+ echo ''
+ echo usage:
usage:
+ cl_options='[--name] [--tgz] [--pip] [--r] [--mvn <mvn-command>]'
+ echo 'make-distribution.sh [--name] [--tgz] [--pip] [--r] [--mvn <mvn-command>] <maven build options>'
make-distribution.sh [--name] [--tgz] [--pip] [--r] [--mvn <mvn-command>] <maven build options>
+ echo 'See Spark'\''s "Building Spark" doc for correct Maven options.'
See Spark's "Building Spark" doc for correct Maven options.
+ echo ''
+ exit 1
```
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27706: [MINOR][BUILD]
Improve readability of the usage of make-distribution.sh
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27706: [MINOR][BUILD] Improve readability of the usage of make-distribution.sh
URL: https://github.com/apache/spark/pull/27706#issuecomment-591396526
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27706: [MINOR][BUILD]
Improve readability of the usage of make-distribution.sh
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27706: [MINOR][BUILD] Improve readability of the usage of make-distribution.sh
URL: https://github.com/apache/spark/pull/27706#issuecomment-591318537
**[Test build #118965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118965/testReport)** for PR 27706 at commit [`32288e9`](https://github.com/apache/spark/commit/32288e9c5bc194054da270a677d390c498c72c4e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27706: [MINOR][BUILD] Improve
readability of the usage of make-distribution.sh
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27706: [MINOR][BUILD] Improve readability of the usage of make-distribution.sh
URL: https://github.com/apache/spark/pull/27706#issuecomment-591318537
**[Test build #118965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118965/testReport)** for PR 27706 at commit [`32288e9`](https://github.com/apache/spark/commit/32288e9c5bc194054da270a677d390c498c72c4e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27706:
[MINOR][BUILD] Improve readability of the usage of make-distribution.sh
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27706: [MINOR][BUILD] Improve readability of the usage of make-distribution.sh
URL: https://github.com/apache/spark/pull/27706#issuecomment-591319094
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27706: [MINOR][BUILD]
Fix make-distribution.sh to show usage without 'echo' cmd
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27706: [MINOR][BUILD] Fix make-distribution.sh to show usage without 'echo' cmd
URL: https://github.com/apache/spark/pull/27706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27706:
[MINOR][BUILD] Improve readability of the usage of make-distribution.sh
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27706: [MINOR][BUILD] Improve readability of the usage of make-distribution.sh
URL: https://github.com/apache/spark/pull/27706#issuecomment-591396535
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118965/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27706: [MINOR][BUILD] Improve
readability of the usage of make-distribution.sh
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27706: [MINOR][BUILD] Improve readability of the usage of make-distribution.sh
URL: https://github.com/apache/spark/pull/27706#issuecomment-591395720
**[Test build #118965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118965/testReport)** for PR 27706 at commit [`32288e9`](https://github.com/apache/spark/commit/32288e9c5bc194054da270a677d390c498c72c4e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27706:
[MINOR][BUILD] Improve readability of the usage of make-distribution.sh
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27706: [MINOR][BUILD] Improve readability of the usage of make-distribution.sh
URL: https://github.com/apache/spark/pull/27706#issuecomment-591396526
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27706: [MINOR][BUILD]
Improve readability of the usage of make-distribution.sh
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27706: [MINOR][BUILD] Improve readability of the usage of make-distribution.sh
URL: https://github.com/apache/spark/pull/27706#issuecomment-591319094
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27706:
[MINOR][BUILD] Improve readability of the usage of make-distribution.sh
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27706: [MINOR][BUILD] Improve readability of the usage of make-distribution.sh
URL: https://github.com/apache/spark/pull/27706#issuecomment-591319102
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23713/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27706: [MINOR][BUILD]
Improve readability of the usage of make-distribution.sh
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27706: [MINOR][BUILD] Improve readability of the usage of make-distribution.sh
URL: https://github.com/apache/spark/pull/27706#issuecomment-591396535
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118965/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27706: [MINOR][BUILD]
Improve readability of the usage of make-distribution.sh
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27706: [MINOR][BUILD] Improve readability of the usage of make-distribution.sh
URL: https://github.com/apache/spark/pull/27706#issuecomment-591319102
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23713/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org