You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/12 10:55:23 UTC
[GitHub] [pulsar-helm-chart] LoveEachDay opened a new pull request, #258: Fix PodMonitor name conflicts for multiple releases in same namespace
LoveEachDay opened a new pull request, #258:
URL: https://github.com/apache/pulsar-helm-chart/pull/258
Signed-off-by: Edward Zeng <ji...@zilliz.com>
Fixes #257
### Motivation
Fix PodMonitor name conflicts for multiple releases in same namespace
### Modifications
Use release name instead of hardcode `pulsar.name` for pod monitor name.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a diff in pull request #258: Fix PodMonitor name conflicts for multiple releases in same namespace
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on code in PR #258:
URL: https://github.com/apache/pulsar-helm-chart/pull/258#discussion_r998565059
##########
charts/pulsar/templates/bookkeeper-podmonitor.yaml:
##########
@@ -22,7 +22,7 @@
apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
- name: {{ template "pulsar.name" . }}-bookie
+ name: {{ .Release.Name }}-bookie
Review Comment:
```suggestion
name: {{ template "pulsar.fullname" . }}-bookie
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #258: Fix PodMonitor name conflicts for multiple releases in same namespace
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #258:
URL: https://github.com/apache/pulsar-helm-chart/pull/258#issuecomment-1284913748
We failed the lint-test for the previous commit due to an unexpected error. I merged master into this branch to get the latest tests to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] LoveEachDay commented on pull request #258: Fix PodMonitor name conflicts for multiple releases in same namespace
Posted by GitBox <gi...@apache.org>.
LoveEachDay commented on PR #258:
URL: https://github.com/apache/pulsar-helm-chart/pull/258#issuecomment-1096573551
/cc @tuteng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall closed pull request #258: Fix PodMonitor name conflicts for multiple releases in same namespace
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #258: Fix PodMonitor name conflicts for multiple releases in same namespace
URL: https://github.com/apache/pulsar-helm-chart/pull/258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #258: Fix PodMonitor name conflicts for multiple releases in same namespace
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #258:
URL: https://github.com/apache/pulsar-helm-chart/pull/258#issuecomment-1284904947
In order to include this in the upcoming release, I committed my suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #258: Fix PodMonitor name conflicts for multiple releases in same namespace
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #258:
URL: https://github.com/apache/pulsar-helm-chart/pull/258#issuecomment-1285968155
Closing and re-opening to get the latest changes to the CI pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall merged pull request #258: Fix PodMonitor name conflicts for multiple releases in same namespace
Posted by GitBox <gi...@apache.org>.
michaeljmarshall merged PR #258:
URL: https://github.com/apache/pulsar-helm-chart/pull/258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall closed pull request #258: Fix PodMonitor name conflicts for multiple releases in same namespace
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #258: Fix PodMonitor name conflicts for multiple releases in same namespace
URL: https://github.com/apache/pulsar-helm-chart/pull/258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org