You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/11/10 00:35:29 UTC
[kudu-CR] test util: prefer test dir over GetTestDataDirectory()
Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5028
to review the following change.
Change subject: test_util: prefer test_dir_ over GetTestDataDirectory()
......................................................................
test_util: prefer test_dir_ over GetTestDataDirectory()
The latter is more expensive to call. Originally I wanted to restrict it
entirely to KuduTest, but there are a couple places where we don't have a
KuduTest but need to call (e.g. mini cluster constructors).
Change-Id: Ife4dbbe6002b0dbd0a0699fc3a475c9d6f43bcf7
---
M src/kudu/consensus/log_index-test.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/block_manager_util-test.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env_util-test.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
12 files changed, 57 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/5028/1
--
To view, visit http://gerrit.cloudera.org:8080/5028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife4dbbe6002b0dbd0a0699fc3a475c9d6f43bcf7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] test util: prefer test dir over GetTestDataDirectory()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: test_util: prefer test_dir_ over GetTestDataDirectory()
......................................................................
test_util: prefer test_dir_ over GetTestDataDirectory()
The latter is more expensive to call. Originally I wanted to restrict it
entirely to KuduTest, but there are a couple places where we don't have a
KuduTest but need to call (e.g. mini cluster constructors).
Change-Id: Ife4dbbe6002b0dbd0a0699fc3a475c9d6f43bcf7
Reviewed-on: http://gerrit.cloudera.org:8080/5028
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/consensus/log_index-test.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/block_manager_util-test.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env_util-test.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
12 files changed, 57 insertions(+), 61 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife4dbbe6002b0dbd0a0699fc3a475c9d6f43bcf7
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] test util: prefer test dir over GetTestDataDirectory()
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: test_util: prefer test_dir_ over GetTestDataDirectory()
......................................................................
Patch Set 1: Code-Review+1
Did you consider short circuiting calls to GetTestDataDirectory if test_dir_ is set? It would be a bit tricky since test_dir_ isn't necessarily initialized yet when called in the ctor.
--
To view, visit http://gerrit.cloudera.org:8080/5028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4dbbe6002b0dbd0a0699fc3a475c9d6f43bcf7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] test util: prefer test dir over GetTestDataDirectory()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: test_util: prefer test_dir_ over GetTestDataDirectory()
......................................................................
Patch Set 1:
> Did you consider short circuiting calls to GetTestDataDirectory if
> test_dir_ is set? It would be a bit tricky since test_dir_ isn't
> necessarily initialized yet when called in the ctor.
You mean routing calls GetTestDataDirectory() to just return test_dir_ if it's set? The problem is that GetTestDataDirectory() is a free function, and it can't be a KuduTest member because it's called in mini cluster constructors where there's no KuduTest instance.
--
To view, visit http://gerrit.cloudera.org:8080/5028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4dbbe6002b0dbd0a0699fc3a475c9d6f43bcf7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] test util: prefer test dir over GetTestDataDirectory()
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: test_util: prefer test_dir_ over GetTestDataDirectory()
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4dbbe6002b0dbd0a0699fc3a475c9d6f43bcf7
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No