You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/02/02 18:24:47 UTC

[GitHub] [logging-log4j2] avandeursen edited a comment on pull request #720: Expand test suite and fix NPE for StructuredDataLookup class

avandeursen edited a comment on pull request #720:
URL: https://github.com/apache/logging-log4j2/pull/720#issuecomment-1028227148


   This PR seems a bit stalled. I  understand everyone is super busy, so let me briefly explain why I think it's important to merge it:
   
   - Doing a lookup in structured data with a null key is valid according to the API documentation, but yields a null pointer exception
   - This is a bug in the code that is easily fixed by just swapping the arguments of two equality checks.
   
   This  PR fixes  the bug, and provides a systematic set of  test cases for the class, exposing the bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org