[jira] [Commented] (TAJO-167) Implement GeneralSetFunctionExpr to represent all SQL standard set functions.

["Jinho Kim (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761565#comment-13761565 ] 

Jinho Kim commented on TAJO-167:
--------------------------------

+1 
Looks great for me.  I've verified 'mvn clean install'.
                
> Implement GeneralSetFunctionExpr to represent all SQL standard set functions.
> -----------------------------------------------------------------------------
>
>                 Key: TAJO-167
>                 URL: https://issues.apache.org/jira/browse/TAJO-167
>             Project: Tajo
>          Issue Type: Improvement
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.2-incubating
>
>         Attachments: TAJO-167.patch
>
>
> This patch removes CountValueFunctionExpr and add GeneralSetFunctionExpr corresponding to general_set_function of SQL 2003 BNF (http://savage.net.au/SQL/sql-2003-2.bnf.html#general set function).
> After this patch, we should use GeneralSetFunctionExpr to represent all SQL standard aggregation functions (e.g., max, min, avg, sum, stddev_pop, stddev_samp and so on).
> Also, GeneralSetFunctionExpr has an attribute for distinct keyword that set functions can have.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira