You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2024/11/19 12:02:54 UTC
[PR] Data, Flink, Spark: Set PUFFIN as delete file format for V3 [iceberg]
nastra opened a new pull request, #11588:
URL: https://github.com/apache/iceberg/pull/11588
this is part of #11122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [WIP]: Data, Flink, Spark: Set PUFFIN as delete file format for V3 [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #11588:
URL: https://github.com/apache/iceberg/pull/11588#discussion_r1916175700
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -792,13 +794,14 @@ private static class Context implements Serializable {
Schema dataSchema,
SparkWriteConf writeConf,
LogicalWriteInfo info,
- SparkWriteRequirements writeRequirements) {
+ SparkWriteRequirements writeRequirements,
+ int formatVersion) {
this.dataSchema = dataSchema;
this.dataSparkType = info.schema();
this.dataFileFormat = writeConf.dataFileFormat();
this.targetDataFileSize = writeConf.targetDataFileSize();
this.deleteSparkType = info.rowIdSchema().get();
- this.deleteFileFormat = writeConf.deleteFileFormat();
+ this.deleteFileFormat = formatVersion >= 3 ? FileFormat.PUFFIN : writeConf.deleteFileFormat();
Review Comment:
Isn't this redundant with the `useDVs` below? When going for `PUFFIN`, it implies that it uses DVs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [WIP]: Data, Flink, Spark: Set PUFFIN as delete file format for V3 [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11588:
URL: https://github.com/apache/iceberg/pull/11588#issuecomment-2555996648
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [WIP]: Data, Flink, Spark: Set PUFFIN as delete file format for V3 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra closed pull request #11588: [WIP]: Data, Flink, Spark: Set PUFFIN as delete file format for V3
URL: https://github.com/apache/iceberg/pull/11588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org