You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/18 06:13:19 UTC

[GitHub] [spark] itholic commented on a diff in pull request #39638: [SPARK-42082][SPARK-41598][PYTHON] Introduce `PySparkValueError` and `PySparkTypeError`

itholic commented on code in PR #39638:
URL: https://github.com/apache/spark/pull/39638#discussion_r1073130005


##########
python/pyspark/errors/__init__.py:
##########
@@ -18,9 +18,29 @@
 """
 PySpark exceptions.
 """
-from pyspark.errors.exceptions import PySparkException

Review Comment:
   FYI: The changes here and `python/pyspark/errors/exceptions.py` will come from https://github.com/apache/spark/pull/39591 as well.
   
   I manually update these file in advance to manage the test cases.



##########
python/pyspark/errors/exceptions.py:
##########
@@ -15,8 +15,13 @@
 # limitations under the License.
 #
 
-from typing import Dict, Optional, cast

Review Comment:
   ditto.
   
   The changes here will come from https://github.com/apache/spark/pull/39591 when it's merged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org