You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "infdahai (via GitHub)" <gi...@apache.org> on 2023/05/21 13:49:42 UTC

[GitHub] [incubator-kvrocks] infdahai opened a new issue, #1460: Add the support of the ZRANGESTORE command

infdahai opened a new issue, #1460:
URL: https://github.com/apache/incubator-kvrocks/issues/1460

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   This issue considers to support the [zrangestore](https://redis.io/commands/zrangestore/) command.
   
   ### Solution
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1460: Add the support of the ZRANGESTORE command

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1460:
URL: https://github.com/apache/incubator-kvrocks/issues/1460#issuecomment-1569515785

   @jihuayu Assigned,thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] jihuayu commented on issue #1460: Add the support of the ZRANGESTORE command

Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on issue #1460:
URL: https://github.com/apache/incubator-kvrocks/issues/1460#issuecomment-1573826940

   In this command. I used `ZSet#RangeByLex` get members and use `ZSet#Add` add them to new zset.
   But `ZSet#Add` need MemberScore(member+score), `ZSet#RangeByLex` only return member.
   
   So I have 3 way to solve it.
   1. After I use `ZSet#RangeByLex` get members, use `ZSet#Score` to get it score. It may cost additional performance overhead.
   2. Add a new `ZSet#RangeByLex` function that return `MemberScore`. 
   3. Change the `ZSet#RangeByLex` function make it return MemberScore. I found we have already get the socre in `ZSet#RangeByLex` function , so return `MemberScore` will not incur additional performance overhead.
   
   I think 3rd is best. Is it OK?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk closed issue #1460: Add the support of the ZRANGESTORE command

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk closed issue #1460: Add the support of the ZRANGESTORE command
URL: https://github.com/apache/incubator-kvrocks/issues/1460


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] jihuayu commented on issue #1460: Add the support of the ZRANGESTORE command

Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on issue #1460:
URL: https://github.com/apache/incubator-kvrocks/issues/1460#issuecomment-1569514597

   Hello, I can do this task. Can I submit a PR!
   
   According to my understanding, I can use `RangeByRank` function to get elements from the src zset, and then use `Add` function to add them to the dst zset.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1460: Add the support of the ZRANGESTORE command

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1460:
URL: https://github.com/apache/incubator-kvrocks/issues/1460#issuecomment-1574774176

   @jihuayu Yes, the 3rd solution sounds good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org