[GitHub] flink pull request #5878: [FLINK-9216][Streaming] Fix comparator violation

[Xpray <gi...@git.apache.org>]

GitHub user Xpray opened a pull request:

    https://github.com/apache/flink/pull/5878

    [FLINK-9216][Streaming] Fix comparator violation

    ## What is the purpose of the change
    
    Fix Improper Comparator for sorting Operator Id.
    
    ## Brief change log
    - if both ids are sink id, then compare its value, or put sink id at the back.
    
    
    ## Verifying this change
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not documented


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Xpray/flink FLINK-9216

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5878.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5878
    
----
commit 55e54228e1290bc20af56f831c3d02f70e56159a
Author: Xpray <le...@...>
Date:   2018-04-19T06:51:34Z

    [FLINK-9216][Streaming] Fix comparator violation

----


---

[GitHub] flink issue #5878: [FLINK-9216][Streaming] Fix comparator violation

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5878
  
    Good fix, thanks!
    
    Could you add a test for this? That is important to ensure this fix is not accidentally broken again in the future...


---

[GitHub] flink issue #5878: [FLINK-9216][Streaming] Fix comparator violation

[Xpray <gi...@git.apache.org>]

Github user Xpray commented on the issue:

    https://github.com/apache/flink/pull/5878
  
    @StephanEwen I've added a test case, please have a look. Best.


---

[GitHub] flink pull request #5878: [FLINK-9216][Streaming] Fix comparator violation

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5878


---

[GitHub] flink issue #5878: [FLINK-9216][Streaming] Fix comparator violation

[zentol <gi...@git.apache.org>]

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5878
  
    Will verify that the test fails without the fix and merge it afterwards.


---