[GitHub] [beam] lukecwik commented on a change in pull request #11972: [BEAM-9852] Do not create data channel for empty timer descriptor.

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #11972:
URL: https://github.com/apache/beam/pull/11972#discussion_r438371296



##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -819,7 +819,8 @@ def __init__(self,
     # There is no guarantee that the runner only set
     # timer_api_service_descriptor when having timers. So this field cannot be
     # used as an indicator of timers.
-    if self.process_bundle_descriptor.timer_api_service_descriptor:
+    if (self.process_bundle_descriptor.timer_api_service_descriptor and

Review comment:
       I think the same problem exists here:
   https://github.com/apache/beam/blob/89fc35b87d5dc074d25d60a97bb96d71e04be283/sdks/python/apache_beam/runners/worker/sdk_worker.py#L691
   
   Is there a way to see if the api service descriptor isn't the default instance instead of checking for the URL parameter?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org