You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tessbianchi <gi...@git.apache.org> on 2017/11/17 20:14:36 UTC
[GitHub] zeppelin pull request #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior...
GitHub user tessbianchi opened a pull request:
https://github.com/apache/zeppelin/pull/2677
[ZEPPELIN-3062] Removes ctrl+s default behavior from notebook
### What is this PR for?
As a programmer I habitually press CTRL + S out of fear for my sanity.
Other web text editing tools (google docs, jupyter notebooks) ignore the base functionality of CTRL + S of saving the HTML page, and do nothing instead.
This is a small change that will makes the user experience of Zeppelin notebooks much much better.
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3062
### How should this be tested?
* I tested manually:
1. Ran `yarn run dev`
2. Went to `localhost:9000`
3. Created a new note, now anytime a user presses 'CTRL+S' in the scope of the note nothing happens, and the user can continue coding uninterrupted.
### Screenshots (if appropriate)
### Questions:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tessbianchi/zeppelin ZEPPELIN-3062
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2677.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2677
----
commit d7e3315f58743217a1ef46d5a8195ae3e805d880
Author: Tess <te...@gmail.com>
Date: 2017-11-01T00:48:45Z
Removes ctrl+s default behavior from notebook
----
---
[GitHub] zeppelin pull request #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2677
---
[GitHub] zeppelin issue #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior from n...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2677
I'll merge to master if no further comments! Thanks @tessbianchi.
---
[GitHub] zeppelin issue #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior from n...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2677
Thanks @tessbianchi for the contribution! It looks great to me.
One thing is OSX uses `Command` + `S` instead of `CTRL` + `S` for saving HTML page shortcut.
Do you think you can handle `Command` + `S` also in this PR?
---
[GitHub] zeppelin issue #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior from n...
Posted by kjmrknsn <gi...@git.apache.org>.
Github user kjmrknsn commented on the issue:
https://github.com/apache/zeppelin/pull/2677
I tested that `Command` + `s` was ignored successfully on Mac.
---
[GitHub] zeppelin issue #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior from n...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2677
Tested on my mac and windows. works well.
LGTM!
---
[GitHub] zeppelin issue #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior from n...
Posted by tessbianchi <gi...@git.apache.org>.
Github user tessbianchi commented on the issue:
https://github.com/apache/zeppelin/pull/2677
Roger! Thanks!
---
[GitHub] zeppelin issue #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior from n...
Posted by tessbianchi <gi...@git.apache.org>.
Github user tessbianchi commented on the issue:
https://github.com/apache/zeppelin/pull/2677
Alright added support for the command key. However, I do not have a mac and couldn't test it.
I implemented the second answer on [https://stackoverflow.com/questions/3902635/how-does-one-capture-a-macs-command-key-via-javascript](this) stackoverflow.
---
[GitHub] zeppelin issue #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior from n...
Posted by tessbianchi <gi...@git.apache.org>.
Github user tessbianchi commented on the issue:
https://github.com/apache/zeppelin/pull/2677
Can someone approve?
---
[GitHub] zeppelin issue #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior from n...
Posted by tessbianchi <gi...@git.apache.org>.
Github user tessbianchi commented on the issue:
https://github.com/apache/zeppelin/pull/2677
Yes of course!
---