You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/09/10 01:12:42 UTC

[GitHub] [druid] suneet-s commented on pull request #11606: Make ldap group attribute id configurable

suneet-s commented on pull request #11606:
URL: https://github.com/apache/druid/pull/11606#issuecomment-916555363


   Thanks for the contribution @nikhil-ddu !
   
   Have you considered adding an integration test for these new parameters? I think `ITBasicAuthLdapConfigurationTest` is a potential place to add the test.
   
   The docker compose file to set up the cluster for ldap tests appears to be in `docker-compose.ldap-security.yml`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org