You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/10/27 01:58:13 UTC
[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13489: feat(tooltip): added marker options. close #13413
susiwen8 commented on a change in pull request #13489:
URL: https://github.com/apache/incubator-echarts/pull/13489#discussion_r512369355
##########
File path: src/util/format.ts
##########
@@ -215,6 +216,11 @@ export function getTooltipMarker(inOpt: ColorString | GetTooltipMarkerOpt, extra
const type = opt.type;
extraCssText = opt.extraCssText;
const renderMode = opt.renderMode || 'html';
+ let size = opt.size;
Review comment:
Where does `size` pass into function, Did you forget to commit `tooltipMarkup.ts`?
##########
File path: src/component/tooltip/tooltipMarkup.ts
##########
@@ -485,7 +485,8 @@ export class TooltipMarkupStyleCreator {
color: colorStr,
type: markerType,
renderMode,
- markerId: markerId
+ markerId: markerId,
+ size: "10px"
Review comment:
lint: please use `'` single quote
##########
File path: src/util/format.ts
##########
@@ -227,7 +233,7 @@ export function getTooltipMarker(inOpt: ColorString | GetTooltipMarkerOpt, extra
// Only support string
+ encodeHTML(color) + ';' + (extraCssText || '') + '"></span>'
: '<span style="display:inline-block;margin-right:4px;'
- + 'border-radius:10px;width:10px;height:10px;background-color:'
+ + 'border-radius:' + size + ';width:' + size + ';height:' + size + ';background-color:'
Review comment:
There are two `rendermode` for `tooltip`: `html` and `canvas`. You should also change code in `canvas` mode. just below it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org