You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/20 19:49:05 UTC
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6439
Change subject: [DOCS] Replace LZO setup instructions with placeholder
......................................................................
[DOCS] Replace LZO setup instructions with placeholder
An "under construction" banner since non-Cloudera-specific
URLs are not available at this time, and the information
itself may be out of date / inapplicable for Apache Impala
project users.
Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
---
M docs/topics/impala_txtfile.xml
1 file changed, 1 insertion(+), 118 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/6439/1
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: [DOCS] Replace LZO setup instructions with placeholder
......................................................................
Patch Set 4: Code-Review+1
Patch 4 builds cleanly and the content renders well in the html & pdf output.
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#3).
Change subject: [DOCS] Replace LZO setup instructions with placeholder
......................................................................
[DOCS] Replace LZO setup instructions with placeholder
An "under construction" banner since non-Cloudera-specific
URLs are not available at this time, and the information
itself may be out of date / inapplicable for Apache Impala
project users.
Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
---
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_txtfile.xml
2 files changed, 4 insertions(+), 121 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/6439/3
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Replace LZO setup instructions with placeholder
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6439/1/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:
PS1, Line 538:
> Replace this 'cdh' portion of the filename with a generic placeholder.
Done
http://gerrit.cloudera.org:8080/#/c/6439/2/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:
PS2, Line 562:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
> IN particular this section and one at the top seem likely to be universal,
I'm happy either way. With partial instructions left in, Apache Impala users might be able to puzzle through the rest of it themselves. I'll put those pieces back. It isn't clear to me though exactly how much of the earlier stuff is really relevant. (Will Apache Impala users run any apt-get / yum / zypper commands at all or would they be building both impala-lzo and hadoop-lzo from source?)
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Genericize LZO setup instructions
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Genericize LZO setup instructions
......................................................................
Patch Set 5: Code-Review+2
All comments addressed and 2 +1s.
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize LZO setup instructions
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Laurel Hale,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6439
to look at the new patch set (#5).
Change subject: [DOCS] Genericize LZO setup instructions
......................................................................
[DOCS] Genericize LZO setup instructions
Take out the Cloudera-specific download URLs
for the impala-lzo package.
Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
---
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_txtfile.xml
2 files changed, 4 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/6439/5
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: [DOCS] Replace LZO setup instructions with placeholder
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6439/2/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:
PS2, Line 562:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
IN particular this section and one at the top seem likely to be universal, no matter which LZO library is used
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Replace LZO setup instructions with placeholder
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6439/1/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:
PS1, Line 538: cdh4-0.4.15
Replace this 'cdh' portion of the filename with a generic placeholder.
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Laurel Hale,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6439
to look at the new patch set (#4).
Change subject: [DOCS] Replace LZO setup instructions with placeholder
......................................................................
[DOCS] Replace LZO setup instructions with placeholder
An "under construction" banner since non-Cloudera-specific
URLs are not available at this time, and the information
itself may be out of date / inapplicable for Apache Impala
project users.
Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
---
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_txtfile.xml
2 files changed, 9 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/6439/4
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: [DOCS] Replace LZO setup instructions with placeholder
......................................................................
Patch Set 2:
I thought the plan was to leave in as much as possible about LZO?
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: [DOCS] Replace LZO setup instructions with placeholder
......................................................................
Patch Set 3: Code-Review+1
Builds cleanly and renders well in both html & pdf.
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: [DOCS] Replace LZO setup instructions with placeholder
......................................................................
[DOCS] Replace LZO setup instructions with placeholder
An "under construction" banner since non-Cloudera-specific
URLs are not available at this time, and the information
itself may be out of date / inapplicable for Apache Impala
project users.
Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
---
M docs/topics/impala_txtfile.xml
1 file changed, 3 insertions(+), 120 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/6439/2
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] [DOCS] Genericize LZO setup instructions
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize LZO setup instructions
......................................................................
Patch Set 5:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/106/
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize LZO setup instructions
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: [DOCS] Genericize LZO setup instructions
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Replace LZO setup instructions with placeholder
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6439/4/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:
PS4, Line 491: <note>
: <p>
: The download details for the <codeph>impala-lzo</codeph> package are under construction.
: </p>
: </note>
After discussion, decided to take out this <note> too.
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Genericize LZO setup instructions
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: [DOCS] Genericize LZO setup instructions
......................................................................
[DOCS] Genericize LZO setup instructions
Take out the Cloudera-specific download URLs
for the impala-lzo package.
Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Reviewed-on: http://gerrit.cloudera.org:8080/6439
Reviewed-by: Jim Apple <jb...@apache.org>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_txtfile.xml
2 files changed, 4 insertions(+), 31 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Jim Apple: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Replace LZO setup instructions with placeholder
......................................................................
Patch Set 3:
Patch set 2 = fix a stray 'cdh' inside the same impala_txtfile page.
Patch set 3 = fix a reference to the old package name including -cdh4 that I had genericized elsewhere.
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize LZO setup instructions
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize LZO setup instructions
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No