You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/11 02:34:14 UTC

[GitHub] sunjincheng121 commented on a change in pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S…

sunjincheng121 commented on a change in pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S…
URL: https://github.com/apache/flink/pull/7403#discussion_r246986459
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
 ##########
 @@ -36,8 +36,8 @@
 
 	private final String edgeId;
 
-	private final StreamNode sourceVertex;
-	private final StreamNode targetVertex;
+	private final int sourceId;
+	private final int targetId;
 
 Review comment:
   We usually name node id to vertexID， So I suggest that: 
   ```
   	private final int sourceVertexId;
   	private final int targetVertexId;
   ```
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services