You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mattisonchao (via GitHub)" <gi...@apache.org> on 2024/09/10 03:39:30 UTC
[PR] Bump io.grpc from 1.56.0 to 1.56.1 [pulsar]
mattisonchao opened a new pull request, #23276:
URL: https://github.com/apache/pulsar/pull/23276
### Motivation
Bump io.grpc from 1.56.0 to 1.56.1 to address this super important fix. https://github.com/grpc/grpc-java/pull/10328
### Modifications
- Bump io.grpc from 1.56.0 to 1.56.1
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] Bump io.grpc from 1.56.0 to 1.56.1 [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23276:
URL: https://github.com/apache/pulsar/pull/23276#issuecomment-2339651187
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23276?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 74.54%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f4a498f`)](https://app.codecov.io/gh/apache/pulsar/commit/f4a498f802df3a919de4a0c8528fd9d9db10b949?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 570 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/23276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #23276 +/- ##
============================================
+ Coverage 73.57% 74.54% +0.97%
- Complexity 32624 34288 +1664
============================================
Files 1877 1926 +49
Lines 139502 145037 +5535
Branches 15299 15856 +557
============================================
+ Hits 102638 108123 +5485
+ Misses 28908 28646 -262
- Partials 7956 8268 +312
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/23276/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/23276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.95% <ø> (+3.37%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/23276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.66% <ø> (+0.33%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/23276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.89% <ø> (+1.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 562 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/23276/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump io.grpc from 1.56.0 to 1.56.1 [pulsar]
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao closed pull request #23276: Bump io.grpc from 1.56.0 to 1.56.1
URL: https://github.com/apache/pulsar/pull/23276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] Bump io.grpc from 1.56.0 to 1.56.1 [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #23276:
URL: https://github.com/apache/pulsar/pull/23276#issuecomment-2339677171
> Bump io.grpc from 1.56.0 to 1.56.1 to address this super important fix. [grpc/grpc-java#10328](https://github.com/grpc/grpc-java/pull/10328)
@mattisonchao Please share the context to others about why this is important for Pulsar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] Bump io.grpc from 1.56.0 to 1.56.1 [pulsar]
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on PR #23276:
URL: https://github.com/apache/pulsar/pull/23276#issuecomment-2339694346
>Please share the context to others about why this is important for Pulsar.
Pulsar is pluggable messaging system. For some plugins that is using GRPC as the RPC framework will affected by this bug. (https://github.com/grpc/grpc-java/pull/10328) the bug will cause the client can't not do reconnecting after hit `UnknownHostException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] Bump io.grpc from 1.56.0 to 1.56.1 [pulsar]
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao merged PR #23276:
URL: https://github.com/apache/pulsar/pull/23276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org