You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by ro...@apache.org on 2009/06/23 20:48:19 UTC

svn commit: r787787 - in /tapestry/tapestry5/trunk/tapestry-core/src: main/java/org/apache/tapestry5/corelib/components/ main/resources/org/apache/tapestry5/ main/resources/org/apache/tapestry5/corelib/components/ test/java/org/apache/tapestry5/integra...

Author: robertdzeigler
Date: Tue Jun 23 18:48:19 2009
New Revision: 787787

URL: http://svn.apache.org/viewvc?rev=787787&view=rev
Log:
TAP5-749: The FormFragment and LinkSubmit components create a hidden field whose id ends with ":hidden"

Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormFragment.java
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java
    tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/linksubmit.js
    tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
    tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/IntegrationTests.java

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormFragment.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormFragment.java?rev=787787&r1=787786&r2=787787&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormFragment.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormFragment.java Tue Jun 23 18:48:19 2009
@@ -186,7 +186,7 @@
 
                 "name", Form.FORM_DATA,
 
-                "id", clientId + ":hidden",
+                "id", clientId + "-hidden",
 
                 "value", componentActions.getClientData()
         );

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java?rev=787787&r1=787786&r2=787787&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java Tue Jun 23 18:48:19 2009
@@ -87,7 +87,7 @@
     {
         this.clientId = clientId;
 
-        String hiddenFieldName = this.clientId + ":hidden";
+        String hiddenFieldName = this.clientId + "-hidden";
 
         if (request.getParameter(hiddenFieldName) != null)
         {

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/linksubmit.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/linksubmit.js?rev=787787&r1=787786&r2=787787&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/linksubmit.js (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/linksubmit.js Tue Jun 23 18:48:19 2009
@@ -25,7 +25,7 @@
     createHidden : function()
     {
         var hidden = new Element("input", { "type":"hidden",
-            "name": this.element.id + ":hidden",
+            "name": this.element.id + "-hidden",
             "value": this.element.id});
 
         this.element.insert({after:hidden});

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js?rev=787787&r1=787786&r2=787787&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js Tue Jun 23 18:48:19 2009
@@ -1469,7 +1469,7 @@
 
         $T(this.element).formFragment = this;
 
-        this.hidden = $(spec.element + ":hidden");
+        this.hidden = $(spec.element + "-hidden");
 
         this.showFunc = Tapestry.ElementEffect[spec.show] || Tapestry.ElementEffect.slidedown;
         this.hideFunc = Tapestry.ElementEffect[spec.hide] || Tapestry.ElementEffect.slideup;

Modified: tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/IntegrationTests.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/IntegrationTests.java?rev=787787&r1=787786&r2=787787&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/IntegrationTests.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/IntegrationTests.java Tue Jun 23 18:48:19 2009
@@ -1787,6 +1787,7 @@
         start("Form Fragment Demo", "Clear");
 
         type("name", "Fred");
+
         // Really, you can't type in the field because it is not visible, but
         // this checks that invisible fields are not processed.
         type("email", "this field is ignored");
@@ -2932,7 +2933,7 @@
     }
 
     @Test
-    public void validation_constraints_from_messages() throws InterruptedException
+    public void validation_constraints_from_messages()
     {
         start("Validation Constraints From Messages");