[jira] [Commented] (FLINK-4354) Implement TaskManager side of heartbeat from ResourceManager

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854029#comment-15854029 ] 

ASF GitHub Bot commented on FLINK-4354:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2770#discussion_r99585837
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ---
    @@ -137,6 +140,7 @@ public ResourceManager(
     		this.jobManagerRegistrations = new HashMap<>(4);
     		this.taskExecutors = new HashMap<>(8);
     		this.leaderSessionId = null;
    +		this.resourceID = ResourceID.generate();
    --- End diff --
    
    I think the `resourceId` should be determined by the `ResourceManagerRunner`.


>  Implement TaskManager side of heartbeat from ResourceManager
> -------------------------------------------------------------
>
>                 Key: FLINK-4354
>                 URL: https://issues.apache.org/jira/browse/FLINK-4354
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Zhijiang Wang
>            Assignee: Zhijiang Wang
>
> The {{ResourceManager}} initiates heartbeat messages via the {{RmLeaderID}}. 
> The {{TaskManager}} transmits its slot availability with each heartbeat. That way, the RM will always know about available slots.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)