You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by "Hyunsik Choi (JIRA)" <ji...@apache.org> on 2014/02/26 04:01:23 UTC

[jira] [Commented] (TAJO-635) Improve tests of query semantic verification

    [ https://issues.apache.org/jira/browse/TAJO-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912460#comment-13912460 ] 

Hyunsik Choi commented on TAJO-635:
-----------------------------------

Created a review request against branch master in reviewboard 
https://reviews.apache.org/r/18506/


> Improve tests of query semantic verification
> --------------------------------------------
>
>                 Key: TAJO-635
>                 URL: https://issues.apache.org/jira/browse/TAJO-635
>             Project: Tajo
>          Issue Type: Bug
>    Affects Versions: 0.8-incubating, 1.0-incubating
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>         Attachments: TAJO-635.patch
>
>
> See TAJO-633. This is caused by some missed visitor functions. When I investigated TAJO-633, I found that there are more missed methods in BasicEvalNodeVisitor and EvalNodeVisitor2. Also, I found that ExprTestBase::testEval() does not use PreLogicalPlanVerifier, LogicalOptimizer, and LogicalPlanVerifier. As a result, query semantic verification has not been tested fully. This patch fixes all of them.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)