[GitHub] spark pull request #17293: [SPARK-19950][SQL] Fix to ignore nullable when df...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17293#discussion_r124450617
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ---
    @@ -370,8 +370,8 @@ case class StructType(fields: Array[StructField]) extends DataType with Seq[Stru
        *
        * 1. If A and B have the same name and data type, they are merged to a field C with the same name
        *    and data type.  C is nullable if and only if either A or B is nullable.
    -   * 2. If A doesn't exist in `that`, it's included in the result schema.
    -   * 3. If B doesn't exist in `this`, it's also included in the result schema.
    +   * 2. If A doesn't exist in `that`, it's included in the result schema with nullable.
    +   * 3. If B doesn't exist in `this`, it's also included in the result schema with nullable.
    --- End diff --
    
    good catch!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org