You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by brennonyork <gi...@git.apache.org> on 2015/03/14 00:37:00 UTC
[GitHub] spark pull request: [SPARK-5790][GraphX]: VertexRDD's won't zip pr...
GitHub user brennonyork opened a pull request:
https://github.com/apache/spark/pull/5023
[SPARK-5790][GraphX]: VertexRDD's won't zip properly for `diff` capability (added tests)
Added tests that @maropu [created](https://github.com/maropu/spark/blob/1f64794b2ce33e64f340e383d4e8a60639a7eb4b/graphx/src/test/scala/org/apache/spark/graphx/VertexRDDSuite.scala) for vertices with differing partition counts. Wanted to make sure his work got captured /merged as its not in the master branch and I don't believe there's a PR out already for it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brennonyork/spark SPARK-5790
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5023.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5023
----
commit 83bbd29b57c26c0063a6136163a8e839145cda39
Author: Brennon York <br...@capitalone.com>
Date: 2015-03-13T23:32:37Z
added maropu's tests for vertices with differing partition counts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5790][GraphX]: VertexRDD's won't zip pr...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5023#issuecomment-79569556
OK, is the idea that these are tests that pass, that should be included, or tests that fail and demonstrate a problem? Jenkins will tell us soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5790][GraphX]: VertexRDD's won't zip pr...
Posted by brennonyork <gi...@git.apache.org>.
Github user brennonyork commented on the pull request:
https://github.com/apache/spark/pull/5023#issuecomment-79532666
/cc @maropu @ankurdave @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5790][GraphX]: VertexRDD's won't zip pr...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5023#issuecomment-80138149
OK to merge, since tests are good. Does this mean SPARK-5790 is essentially resolved by this? sounds like it was fixed separately, and this is about getting in additional tests created by the parallel effort to address this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5790][GraphX]: VertexRDD's won't zip pr...
Posted by brennonyork <gi...@git.apache.org>.
Github user brennonyork commented on the pull request:
https://github.com/apache/spark/pull/5023#issuecomment-80538110
Sorry @srowen I should've been more clear, but yes you're correct. SPARK-5790 ended up duplicating most effort from SPARK-1955, PR #4705, but @maropu had created tests with his that I hadn't included. Wanted to make sure those were captured and, since SPARK-5790 wasn't closed, thought it best to include those here. Does that make sense? Sorry about the confusion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5790][GraphX]: VertexRDD's won't zip pr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5023#issuecomment-79610010
[Test build #28598 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28598/consoleFull) for PR 5023 at commit [`83bbd29`](https://github.com/apache/spark/commit/83bbd29b57c26c0063a6136163a8e839145cda39).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5790][GraphX]: VertexRDD's won't zip pr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5023
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5790][GraphX]: VertexRDD's won't zip pr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5023#issuecomment-79610141
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28598/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5790][GraphX]: VertexRDD's won't zip pr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5023#issuecomment-79532797
[Test build #28598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28598/consoleFull) for PR 5023 at commit [`83bbd29`](https://github.com/apache/spark/commit/83bbd29b57c26c0063a6136163a8e839145cda39).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org