You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kvrocks.apache.org by ti...@apache.org on 2022/09/29 18:49:12 UTC
[incubator-kvrocks] branch unstable updated: Add missing `return`s in redis_metadata.cc (#932)
This is an automated email from the ASF dual-hosted git repository.
tison pushed a commit to branch unstable
in repository https://gitbox.apache.org/repos/asf/incubator-kvrocks.git
The following commit(s) were added to refs/heads/unstable by this push:
new d377b8a Add missing `return`s in redis_metadata.cc (#932)
d377b8a is described below
commit d377b8a9249c488fdcc78e87dd883b2c34ee678f
Author: Aleks Lozovyuk <al...@gmail.com>
AuthorDate: Thu Sep 29 21:49:05 2022 +0300
Add missing `return`s in redis_metadata.cc (#932)
---
src/redis_metadata.cc | 8 ++++----
src/redis_stream.cc | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/redis_metadata.cc b/src/redis_metadata.cc
index f46c049..5c1f4d3 100644
--- a/src/redis_metadata.cc
+++ b/src/redis_metadata.cc
@@ -183,7 +183,7 @@ rocksdb::Status Metadata::Decode(const std::string &bytes) {
GetFixed8(&input, &flags);
GetFixed32(&input, reinterpret_cast<uint32_t *>(&expire));
if (Type() != kRedisString) {
- if (input.size() < 12) rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
+ if (input.size() < 12) return rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
GetFixed64(&input, &version);
GetFixed32(&input, &size);
}
@@ -279,12 +279,12 @@ rocksdb::Status ListMetadata::Decode(const std::string &bytes) {
GetFixed8(&input, &flags);
GetFixed32(&input, reinterpret_cast<uint32_t *>(&expire));
if (Type() != kRedisString) {
- if (input.size() < 12) rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
+ if (input.size() < 12) return rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
GetFixed64(&input, &version);
GetFixed32(&input, &size);
}
if (Type() == kRedisList) {
- if (input.size() < 16) rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
+ if (input.size() < 16) return rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
GetFixed64(&input, &head);
GetFixed64(&input, &tail);
}
@@ -323,7 +323,7 @@ rocksdb::Status StreamMetadata::Decode(const std::string &bytes) {
GetFixed32(&input, reinterpret_cast<uint32_t *>(&expire));
if (input.size() < 12) {
- rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
+ return rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
}
GetFixed64(&input, &version);
diff --git a/src/redis_stream.cc b/src/redis_stream.cc
index 184e8f6..bc402e5 100644
--- a/src/redis_stream.cc
+++ b/src/redis_stream.cc
@@ -79,7 +79,7 @@ rocksdb::Status Stream::Add(const Slice &stream_name, const StreamAddOptions& op
const std::vector<std::string> &args, StreamEntryID *id) {
for (auto const &v : args) {
if (v.size() > INT32_MAX) {
- rocksdb::Status::InvalidArgument("argument length is too high");
+ return rocksdb::Status::InvalidArgument("argument length is too high");
}
}