You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/23 11:56:07 UTC
[GitHub] [hadoop-ozone] elek opened a new pull request #708: HDDS-3239.
Provide message-level metrics from the generic protocol dispatch.
elek opened a new pull request #708: HDDS-3239. Provide message-level metrics from the generic protocol dispatch.
URL: https://github.com/apache/hadoop-ozone/pull/708
## What changes were proposed in this pull request?
Ozone RPC protocols (due to the limitation of protobuf) are very simple: There is only one message per service and the message is routed to the appropriate method based on the type.
It makes very easy to add tracing / metrics as we have one generic dispatcher (OzoneProtocolMessageDispatcher.java) where we implemented opentracing support and basic metric collection.
In this patch I propose to improve this metric to add the message type to the metrics as a tag to make it easier to follow what's going on... (eg. see the distribution of the incoming message types)
We can also measure the total amount of time spent to serve one specific type of requests which can be used to calculate the moving average for latency.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3239
## How was this patch tested?
Deployed to Kubernetes and checked the prometheus metrics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek closed pull request #708: HDDS-3239. Provide
message-level metrics from the generic protocol dispatch.
Posted by GitBox <gi...@apache.org>.
elek closed pull request #708: HDDS-3239. Provide message-level metrics from the generic protocol dispatch.
URL: https://github.com/apache/hadoop-ozone/pull/708
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek removed a comment on issue #708: HDDS-3239.
Provide message-level metrics from the generic protocol dispatch.
Posted by GitBox <gi...@apache.org>.
elek removed a comment on issue #708: HDDS-3239. Provide message-level metrics from the generic protocol dispatch.
URL: https://github.com/apache/hadoop-ozone/pull/708#issuecomment-604981594
Base branch is changed. Please don't merge it from the github web ui, only manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #708: HDDS-3239. Provide
message-level metrics from the generic protocol dispatch.
Posted by GitBox <gi...@apache.org>.
elek commented on issue #708: HDDS-3239. Provide message-level metrics from the generic protocol dispatch.
URL: https://github.com/apache/hadoop-ozone/pull/708#issuecomment-604981594
Base branch is changed. Please don't merge it from the github web ui, only manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org