You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "anxkhn (via GitHub)" <gi...@apache.org> on 2026/07/06 12:42:28 UTC
[PR] Fix typo in Pig script schema mismatch error message [calcite]
anxkhn opened a new pull request, #5084:
URL: https://github.com/apache/calcite/pull/5084
## Jira Link
Not required. Per the PR template and the contributing guide, a Jira issue is not
needed for typos and cosmetic changes. This PR only fixes a misspelling in a
user-facing exception message; there is no behavioral change.
## Changes Proposed
Fixes a typo in the `IllegalArgumentException` thrown by
`PigRelBuilder.scan(RelOptTable, String...)` when a Pig script schema does not
match the database schema for a table.
The message labelled the user-supplied schema line `Scrip schema:` instead of
`Script schema:`. The surrounding text ("Pig script schema does not match database
schema for table ...") and the adjacent `Database schema:` line make clear the
intended word is "Script".
Before:
```
Pig script schema does not match database schema for table <names>.
Scrip schema: <userSchema>
Database schema: <systemSchema>
```
After:
```
Pig script schema does not match database schema for table <names>.
Script schema: <userSchema>
Database schema: <systemSchema>
```
The change is a single word in one string literal
(`piglet/src/main/java/org/apache/calcite/piglet/PigRelBuilder.java`); there is no
functional change. `Scrip` (word boundary) now appears nowhere in the repository.
No test is added: no existing test asserts this exception message, and pinning the
exact wording would add brittleness rather than meaningful coverage. `./gradlew
:piglet:autostyleCheck :piglet:checkstyleMain :piglet:compileJava` passes locally
(JDK 21).
---
## Diff
```diff
diff --git a/piglet/src/main/java/org/apache/calcite/piglet/PigRelBuilder.java b/piglet/src/main/java/org/apache/calcite/piglet/PigRelBuilder.java
index df9f57a30..87c467209 100644
--- a/piglet/src/main/java/org/apache/calcite/piglet/PigRelBuilder.java
+++ b/piglet/src/main/java/org/apache/calcite/piglet/PigRelBuilder.java
@@ -246,7 +246,7 @@ public RelBuilder scan(RelOptTable userSchema, String... tableNames) {
// If both schemas are valid, they must be compatible
throw new IllegalArgumentException(
"Pig script schema does not match database schema for table " + names + ".\n"
- + "\t Scrip schema: " + userSchema.getRowType().getFullTypeString() + "\n"
+ + "\t Script schema: " + userSchema.getRowType().getFullTypeString() + "\n"
+ "\t Database schema: " + systemSchema.getRowType().getFullTypeString());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typo in Pig script schema mismatch error message [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5084:
URL: https://github.com/apache/calcite/pull/5084#issuecomment-4893040885
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5084) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5084&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5084&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=5084&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5084&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5084&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5084)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typo in Pig script schema mismatch error message [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #5084:
URL: https://github.com/apache/calcite/pull/5084#issuecomment-4892973095
Avoid using "Fix" in titles and commit messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change typos in exception messages [calcite]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #5084:
URL: https://github.com/apache/calcite/pull/5084#issuecomment-4900681505
> @xuzifu666 Thanks for the feedback. I have consolidated the related typo changes into this PR, updated the PR title and description, rebased the branch on the latest `main`, and kept the changes as three commits with commit messages starting with `Change`. I also closed #5083 and #5085 as superseded by this PR.
I feel it is OK and approved it; grouping similar typos together for review saves time for other reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change typos in exception messages [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu merged PR #5084:
URL: https://github.com/apache/calcite/pull/5084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change typos in exception messages [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5084:
URL: https://github.com/apache/calcite/pull/5084#issuecomment-4900586695
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5084) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5084&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5084&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=5084&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5084&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5084&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5084)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct typo in Pig script schema mismatch error message [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #5084:
URL: https://github.com/apache/calcite/pull/5084#issuecomment-4898425006
Please note that your commit message also needs to be updated; the first letter must be capitalized. The same applies to other PRs—simply changing the PR title is not enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change typos in exception messages [calcite]
Posted by "anxkhn (via GitHub)" <gi...@apache.org>.
anxkhn commented on PR #5084:
URL: https://github.com/apache/calcite/pull/5084#issuecomment-4900453292
@xuzifu666 Thanks for the feedback. I have consolidated the related typo changes into this PR, updated the PR title and description, rebased the branch on the latest `main`, and kept the changes as three commits with commit messages starting with `Change`. I also closed #5083 and #5085 as superseded by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org