You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/06/22 02:40:19 UTC

[GitHub] [incubator-eventmesh] lrhkobe opened a new pull request, #947: [ISSUE #946] trace optimization

lrhkobe opened a new pull request, #947:
URL: https://github.com/apache/incubator-eventmesh/pull/947

   
   Fixes ISSUE #946 .
   
   ### Motivation
   
   - The trace implementation is relatively simple, only supported in httpserver
   - The attributes reported by the trace are incomplete, for example, the specific time and passed node attributes are missing
   
   
   
   ### Modifications
   
   - Adjust eventmesh-trace-api，which is based on opentelemetry-api
   
   ```
   public interface EventMeshTraceService {
       void init() throws TraceException;
   
       //extract attr from carrier to context
       Context extractFrom(Context context, Map<String, Object> carrier) throws TraceException;
   
       //inject attr from context to carrier
       void inject(Context context, Map<String, Object> carrier);
   
       Span createSpan(String spanName, SpanKind spanKind, long startTimestamp, TimeUnit timeUnit,
                       Context context, boolean isSpanFinishInOtherThread) throws TraceException;
   
       Span createSpan(String spanName, SpanKind spanKind, Context context,
                       boolean isSpanFinishInOtherThread) throws TraceException;
   
       void shutdown() throws TraceException;
   }
   ```
   
   - Provide a more specific trace implementation，add trace buried point in eventmesh-runtime
   Record various times of the event in its life cycle,  record the ip of the eventmesh that the event passed through and other attributes which your business attentioned.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] lrhkobe closed pull request #947: [ISSUE #946] trace optimization

Posted by GitBox <gi...@apache.org>.
lrhkobe closed pull request #947: [ISSUE #946] trace optimization 
URL: https://github.com/apache/incubator-eventmesh/pull/947


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org