You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "srinireddy2020 (via GitHub)" <gi...@apache.org> on 2026/02/07 14:48:45 UTC
[PR] HBASE-29871 During WAL write times out add DataNode address in. the exception message [hbase]
srinireddy2020 opened a new pull request, #7719:
URL: https://github.com/apache/hbase/pull/7719
For better debug, add datanode address to the exception message during WAL write times out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29871 During WAL write times out add DataNode address in. the exception message [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #7719:
URL: https://github.com/apache/hbase/pull/7719#issuecomment-3874852390
Please fix the spotless issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29871 During WAL write times out add DataNode address in. the exception message [hbase]
Posted by "guluo2016 (via GitHub)" <gi...@apache.org>.
guluo2016 commented on code in PR #7719:
URL: https://github.com/apache/hbase/pull/7719#discussion_r2788912049
##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:
##########
@@ -345,7 +345,8 @@ protected void channelRead0(ChannelHandlerContext ctx, BlockOpResponseProto resp
if (PipelineAck.isRestartOOBStatus(pipelineStatus)) {
throw new IOException("datanode " + dnInfo + " is restarting");
}
- String logInfo = "ack with firstBadLink as " + resp.getFirstBadLink();
+ String logInfo =
+ "ack with firstBadLink as " + resp.getFirstBadLink() + " from datanode " + dnInfo;
Review Comment:
Overall looks good. Just some minor nits.
In a previous change, we print both the hostname and IP when printing datanode info, details see: https://github.com/apache/hbase/pull/6148
It might be better to follow that same pattern here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29871 During WAL write times out add DataNode address in. the exception message [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 merged PR #7719:
URL: https://github.com/apache/hbase/pull/7719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29871 During WAL write times out add DataNode address in. the exception message [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #7719:
URL: https://github.com/apache/hbase/pull/7719#issuecomment-3934984985
@srinireddy2020 Please do a rebase as our github actions so we can finish the checks? Sorry we have changed the actions a bit so the scripts are broken...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29871 During WAL write times out add DataNode address in. the exception message [hbase]
Posted by "srinireddy2020 (via GitHub)" <gi...@apache.org>.
srinireddy2020 commented on code in PR #7719:
URL: https://github.com/apache/hbase/pull/7719#discussion_r2785669454
##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:
##########
@@ -378,8 +379,8 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exception {
if (evt instanceof IdleStateEvent && ((IdleStateEvent) evt).state() == READER_IDLE) {
- promise
- .tryFailure(new IOException("Timeout(" + timeoutMs + "ms) waiting for response"));
+ promise.tryFailure(new IOException(
Review Comment:
In the method parameter already having the DN details so no need to call channel.remoteAddress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29871 During WAL write times out add DataNode address in. the exception message [hbase]
Posted by "srinireddy2020 (via GitHub)" <gi...@apache.org>.
srinireddy2020 commented on code in PR #7719:
URL: https://github.com/apache/hbase/pull/7719#discussion_r2789767167
##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:
##########
@@ -345,7 +345,8 @@ protected void channelRead0(ChannelHandlerContext ctx, BlockOpResponseProto resp
if (PipelineAck.isRestartOOBStatus(pipelineStatus)) {
throw new IOException("datanode " + dnInfo + " is restarting");
}
- String logInfo = "ack with firstBadLink as " + resp.getFirstBadLink();
+ String logInfo =
+ "ack with firstBadLink as " + resp.getFirstBadLink() + " from datanode " + dnInfo;
Review Comment:
Comment addressed, please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29871 During WAL write times out add DataNode address in. the exception message [hbase]
Posted by "vaijosh (via GitHub)" <gi...@apache.org>.
vaijosh commented on code in PR #7719:
URL: https://github.com/apache/hbase/pull/7719#discussion_r2780638756
##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:
##########
@@ -378,8 +379,8 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
@Override
public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exception {
if (evt instanceof IdleStateEvent && ((IdleStateEvent) evt).state() == READER_IDLE) {
- promise
- .tryFailure(new IOException("Timeout(" + timeoutMs + "ms) waiting for response"));
+ promise.tryFailure(new IOException(
Review Comment:
@srinireddy2020
In other two places we are logging "channel.remoteAddress" in message and here dnInfo.toString.
Can't we keep it consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29871 During WAL write times out add DataNode address in. the exception message [hbase]
Posted by "srinireddy2020 (via GitHub)" <gi...@apache.org>.
srinireddy2020 commented on PR #7719:
URL: https://github.com/apache/hbase/pull/7719#issuecomment-3875207709
> Please fix the spotless issue?
Spot less fixed. please check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org