You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2018/01/25 06:17:15 UTC
Re: Review Request 62533: RANGER-1805: Code improvement to follow best
practices in js
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62533/
-----------------------------------------------------------
(Updated Jan. 25, 2018, 6:17 a.m.)
Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Changes
-------
Updated patch with latest code base.
Bugs: RANGER-1805
https://issues.apache.org/jira/browse/RANGER-1805
Repository: ranger
Description
-------
Javascript coding best practices.
Diffs (updated)
-----
security-admin/src/main/webapp/scripts/modules/XAOverrides.js 5810d5d
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8c9f284
security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939
security-admin/src/main/webapp/scripts/utils/XATemplateHelpers.js 785e2c2
security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js 1b1a4aa
security-admin/src/main/webapp/scripts/views/common/AddGroup.js 81fd901
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 821a86b
security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js ab42b5c
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js c5d7d0e
security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js c5dc053
security-admin/src/main/webapp/scripts/views/user/UserProfileForm.js a385592
security-admin/src/main/webapp/templates/common/Footer_tmpl.html e3accb6
security-admin/src/main/webapp/templates/common/downloadservicepolicy_tmpl.html 49be577
security-admin/src/main/webapp/templates/helpers/XAHelpers.js 9363c6b
security-admin/src/main/webapp/templates/kms/KmsKeyCreate_tmpl.html 2aaac43
security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 31252af
security-admin/src/main/webapp/templates/service/ServiceCreate_tmpl.html d79028e
security-admin/src/main/webapp/templates/users/GroupCreate_tmpl.html c387e68
security-admin/src/main/webapp/templates/users/UserCreate_tmpl.html 204e832
Diff: https://reviews.apache.org/r/62533/diff/2/
Changes: https://reviews.apache.org/r/62533/diff/1-2/
Testing
-------
Done overall basic UI testing which includes service, policy, user, group and permission modules.
Thanks,
Nitin Galave
Re: Review Request 62533: RANGER-1805: Code improvement to follow best
practices in js
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62533/#review196554
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Jan. 25, 2018, 6:17 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62533/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 6:17 a.m.)
>
>
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1805
> https://issues.apache.org/jira/browse/RANGER-1805
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Javascript coding best practices.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/XAOverrides.js 5810d5d
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8c9f284
> security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939
> security-admin/src/main/webapp/scripts/utils/XATemplateHelpers.js 785e2c2
> security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js 1b1a4aa
> security-admin/src/main/webapp/scripts/views/common/AddGroup.js 81fd901
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 821a86b
> security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js ab42b5c
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js c5d7d0e
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js c5dc053
> security-admin/src/main/webapp/scripts/views/user/UserProfileForm.js a385592
> security-admin/src/main/webapp/templates/common/Footer_tmpl.html e3accb6
> security-admin/src/main/webapp/templates/common/downloadservicepolicy_tmpl.html 49be577
> security-admin/src/main/webapp/templates/helpers/XAHelpers.js 9363c6b
> security-admin/src/main/webapp/templates/kms/KmsKeyCreate_tmpl.html 2aaac43
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 31252af
> security-admin/src/main/webapp/templates/service/ServiceCreate_tmpl.html d79028e
> security-admin/src/main/webapp/templates/users/GroupCreate_tmpl.html c387e68
> security-admin/src/main/webapp/templates/users/UserCreate_tmpl.html 204e832
>
>
> Diff: https://reviews.apache.org/r/62533/diff/2/
>
>
> Testing
> -------
>
> Done overall basic UI testing which includes service, policy, user, group and permission modules.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 62533: RANGER-1805: Code improvement to follow best
practices in js
Posted by Pradeep Agrawal <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62533/#review196225
-----------------------------------------------------------
Ship it!
Ship It!
- Pradeep Agrawal
On Jan. 25, 2018, 6:17 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62533/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 6:17 a.m.)
>
>
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1805
> https://issues.apache.org/jira/browse/RANGER-1805
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Javascript coding best practices.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/XAOverrides.js 5810d5d
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8c9f284
> security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939
> security-admin/src/main/webapp/scripts/utils/XATemplateHelpers.js 785e2c2
> security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js 1b1a4aa
> security-admin/src/main/webapp/scripts/views/common/AddGroup.js 81fd901
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 821a86b
> security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js ab42b5c
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js c5d7d0e
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js c5dc053
> security-admin/src/main/webapp/scripts/views/user/UserProfileForm.js a385592
> security-admin/src/main/webapp/templates/common/Footer_tmpl.html e3accb6
> security-admin/src/main/webapp/templates/common/downloadservicepolicy_tmpl.html 49be577
> security-admin/src/main/webapp/templates/helpers/XAHelpers.js 9363c6b
> security-admin/src/main/webapp/templates/kms/KmsKeyCreate_tmpl.html 2aaac43
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 31252af
> security-admin/src/main/webapp/templates/service/ServiceCreate_tmpl.html d79028e
> security-admin/src/main/webapp/templates/users/GroupCreate_tmpl.html c387e68
> security-admin/src/main/webapp/templates/users/UserCreate_tmpl.html 204e832
>
>
> Diff: https://reviews.apache.org/r/62533/diff/2/
>
>
> Testing
> -------
>
> Done overall basic UI testing which includes service, policy, user, group and permission modules.
>
>
> Thanks,
>
> Nitin Galave
>
>