You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "RobertIndie (via GitHub)" <gi...@apache.org> on 2023/03/20 12:14:10 UTC

[GitHub] [pulsar-client-go] RobertIndie commented on a diff in pull request #994: Fix batched messages not ACKed correctly when batch index ACK is disabled

RobertIndie commented on code in PR #994:
URL: https://github.com/apache/pulsar-client-go/pull/994#discussion_r1142024286


##########
pulsar/consumer_partition.go:
##########
@@ -499,6 +499,12 @@ func (pc *partitionConsumer) ackID(msgID MessageID, withResponse bool) error {
 	trackingID := toTrackingMessageID(msgID)
 
 	if trackingID != nil && trackingID.ack() {
+		trackingID = &trackingMessageID{

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org