You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/14 21:02:37 UTC

[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #2536: xtensa/esp32: fixes enable int function and gets apb clk frequency through function

saramonteiro opened a new pull request #2536:
URL: https://github.com/apache/incubator-nuttx/pull/2536


   ## Summary
   
   Fix:
   
   It's missing a configuration in the esp32_tim_enableint and esp32_tim_disableint
   
   Improvement:
   
   Get the APB clock frequency from a function instead of using a constant. So, if this frequency changes in the future, the timer driver will not be affected.
   
   ## Impact
   
   All timers' users.
   
   ## Testing
   Running Timer Example.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] saramonteiro commented on pull request #2536: xtensa/esp32: fixes enable int function and gets apb clk frequency through function

Posted by GitBox <gi...@apache.org>.
saramonteiro commented on pull request #2536:
URL: https://github.com/apache/incubator-nuttx/pull/2536#issuecomment-744709851


   Expect to fail:
   nuttx/arch/xtensa/src/esp32/hardware/esp32_soc.h:455:11: error: Mixed case identifier found
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #2536: xtensa/esp32: fixes enable int function and gets apb clk frequency through function

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2536:
URL: https://github.com/apache/incubator-nuttx/pull/2536


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org