You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@curator.apache.org by ra...@apache.org on 2018/12/02 15:03:36 UTC

curator git commit: added a comment on change

Repository: curator
Updated Branches:
  refs/heads/CURATOR-472 b91036be0 -> 90a3e4c57


added a comment on change


Project: http://git-wip-us.apache.org/repos/asf/curator/repo
Commit: http://git-wip-us.apache.org/repos/asf/curator/commit/90a3e4c5
Tree: http://git-wip-us.apache.org/repos/asf/curator/tree/90a3e4c5
Diff: http://git-wip-us.apache.org/repos/asf/curator/diff/90a3e4c5

Branch: refs/heads/CURATOR-472
Commit: 90a3e4c57a61b8b669103dbc75d92a1810d1e392
Parents: b91036b
Author: randgalt <ra...@apache.org>
Authored: Sun Dec 2 10:03:31 2018 -0500
Committer: randgalt <ra...@apache.org>
Committed: Sun Dec 2 10:03:31 2018 -0500

----------------------------------------------------------------------
 curator-client/src/main/java/org/apache/curator/HandleHolder.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/curator/blob/90a3e4c5/curator-client/src/main/java/org/apache/curator/HandleHolder.java
----------------------------------------------------------------------
diff --git a/curator-client/src/main/java/org/apache/curator/HandleHolder.java b/curator-client/src/main/java/org/apache/curator/HandleHolder.java
index 0917d71..29c3962 100644
--- a/curator-client/src/main/java/org/apache/curator/HandleHolder.java
+++ b/curator-client/src/main/java/org/apache/curator/HandleHolder.java
@@ -157,7 +157,7 @@ class HandleHolder
                 zooKeeper.register(dummyWatcher);   // clear the default watcher so that no new events get processed by mistake
                 if ( waitForShutdownTimeoutMs == 0 )
                 {
-                    zooKeeper.close();
+                    zooKeeper.close();  // coming from closeAndReset() which is executed in ZK's event thread. Cannot use zooKeeper.close(n) otherwise we'd get a dead lock
                 }
                 else
                 {