[jira] [Commented] (ARIES-1692) Add functionality to be able to supply a test query for use in checking pooled connections

["Tim (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARIES-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875289#comment-15875289 ] 

Tim commented on ARIES-1692:
----------------------------

I have attached my attempt to add this functionality, as stated in the patch comments some further mods will be needed.

I have also verified these changes independently using the Trifox Vortex JDBC driver on our system. 

One thing I did not expect is that I also needed to set the ConnectionTestQuery on the HikariConfig used to create the HikariDataSource in our custom DataSourceFactory (the vortex driver does not contain a DataSource/OsgiDataSourceFactory).

> Add functionality to be able to supply a test query for use in checking pooled connections
> ------------------------------------------------------------------------------------------
>
>                 Key: ARIES-1692
>                 URL: https://issues.apache.org/jira/browse/ARIES-1692
>             Project: Aries
>          Issue Type: Improvement
>          Components: tx-control
>    Affects Versions: tx-control-0.0.3
>            Reporter: Tim
>            Priority: Minor
>             Fix For: tx-control-0.0.3
>
>         Attachments: org.apache.aries.tx-control-itests.patch, tx-control-provider-jdbc-local.patch, tx-control-provider-jdbc-xa.patch, tx-control-provider-jpa-common.patch
>
>
> A common feature of pooling libraries is to be able to supply a test query for use in checking pooled connections. Many of the later JDBC drivers do not need this option as the driver implements Connection.isValid(), however some older drivers don't implement this method correctly.
> Add functionality to be able to supply a test query for use in checking pooled connections.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)