You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Alexander Gavrilov (JIRA)" <ji...@apache.org> on 2011/04/22 19:22:06 UTC
[jira] [Created] (TAP5-1511)
RequestSecurityManager#checkPageSecurity should return request security
insed of INSECURE in case when security is disabled
RequestSecurityManager#checkPageSecurity should return request security insed of INSECURE in case when security is disabled
---------------------------------------------------------------------------------------------------------------------------
Key: TAP5-1511
URL: https://issues.apache.org/jira/browse/TAP5-1511
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.2.5
Reporter: Alexander Gavrilov
In current version unless security is enabled RequestSecurityManager#checkPageSecurity always returns LinkSecurity.INSECURE.
It could be better to return LinkSecurity.SECURE or LinkSecurity.INSECURE depends on request security flag.
{code:java}
if (!securityEnabled)
return request.isSecure() ? LinkSecurity.SECURE : LinkSecurity.INSECURE;
{code}
For now even if request to application is come by https tapestry generate http urls for getAbsolueURL call.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1511)
RequestSecurityManager.checkPageSecurity() should return request security
instead of INSECURE in case when security is disabled
Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1511.
--------------------------------------
Resolution: Fixed
Fix Version/s: 5.3
Assignee: Howard M. Lewis Ship
> RequestSecurityManager.checkPageSecurity() should return request security instead of INSECURE in case when security is disabled
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1511
> URL: https://issues.apache.org/jira/browse/TAP5-1511
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Alexander Gavrilov
> Assignee: Howard M. Lewis Ship
> Fix For: 5.3
>
>
> In current version unless security is enabled RequestSecurityManager#checkPageSecurity always returns LinkSecurity.INSECURE.
> It could be better to return LinkSecurity.SECURE or LinkSecurity.INSECURE depends on request security flag.
> {code:java}
> if (!securityEnabled)
> return request.isSecure() ? LinkSecurity.SECURE : LinkSecurity.INSECURE;
> {code}
> For now even if request to application is come by https tapestry generate http urls for getAbsolueURL call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1511)
RequestSecurityManager#checkPageSecurity should return request security
insed of INSECURE in case when security is disabled
Posted by "Alexander Gavrilov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129131#comment-13129131 ]
Alexander Gavrilov commented on TAP5-1511:
------------------------------------------
Https security is not required for our application but must be supported if request comes by https, because we serve pages that can be included into another sites through iframe.
> RequestSecurityManager#checkPageSecurity should return request security insed of INSECURE in case when security is disabled
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1511
> URL: https://issues.apache.org/jira/browse/TAP5-1511
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.5
> Reporter: Alexander Gavrilov
>
> In current version unless security is enabled RequestSecurityManager#checkPageSecurity always returns LinkSecurity.INSECURE.
> It could be better to return LinkSecurity.SECURE or LinkSecurity.INSECURE depends on request security flag.
> {code:java}
> if (!securityEnabled)
> return request.isSecure() ? LinkSecurity.SECURE : LinkSecurity.INSECURE;
> {code}
> For now even if request to application is come by https tapestry generate http urls for getAbsolueURL call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1511)
RequestSecurityManager.checkPageSecurity() should return request security
instead of INSECURE in case when security is disabled
Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1511.
--------------------------------------
Resolution: Fixed
Fix Version/s: 5.3
Assignee: Howard M. Lewis Ship
> RequestSecurityManager.checkPageSecurity() should return request security instead of INSECURE in case when security is disabled
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1511
> URL: https://issues.apache.org/jira/browse/TAP5-1511
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Alexander Gavrilov
> Assignee: Howard M. Lewis Ship
> Fix For: 5.3
>
>
> In current version unless security is enabled RequestSecurityManager#checkPageSecurity always returns LinkSecurity.INSECURE.
> It could be better to return LinkSecurity.SECURE or LinkSecurity.INSECURE depends on request security flag.
> {code:java}
> if (!securityEnabled)
> return request.isSecure() ? LinkSecurity.SECURE : LinkSecurity.INSECURE;
> {code}
> For now even if request to application is come by https tapestry generate http urls for getAbsolueURL call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1511)
RequestSecurityManager#checkPageSecurity should return request security
insed of INSECURE in case when security is disabled
Posted by "Howard M. Lewis Ship (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129100#comment-13129100 ]
Howard M. Lewis Ship commented on TAP5-1511:
--------------------------------------------
Why would security be disabled in a production application? The intent of disabling security is to prevent unwanted http/https handover requests in development.
> RequestSecurityManager#checkPageSecurity should return request security insed of INSECURE in case when security is disabled
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1511
> URL: https://issues.apache.org/jira/browse/TAP5-1511
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.5
> Reporter: Alexander Gavrilov
>
> In current version unless security is enabled RequestSecurityManager#checkPageSecurity always returns LinkSecurity.INSECURE.
> It could be better to return LinkSecurity.SECURE or LinkSecurity.INSECURE depends on request security flag.
> {code:java}
> if (!securityEnabled)
> return request.isSecure() ? LinkSecurity.SECURE : LinkSecurity.INSECURE;
> {code}
> For now even if request to application is come by https tapestry generate http urls for getAbsolueURL call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1511)
RequestSecurityManager.checkPageSecurity() should return request security
instead of INSECURE in case when security is disabled
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134415#comment-13134415 ]
Hudson commented on TAP5-1511:
------------------------------
Integrated in tapestry-trunk-freestyle #605 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/605/])
TAP5-1511: RequestSecurityManager.checkPageSecurity() should return request security instead of INSECURE in case when security is disabled
hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1188278
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/RequestSecurityManager.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/RequestSecurityManagerImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/RequestSecurityManagerImplTest.java
> RequestSecurityManager.checkPageSecurity() should return request security instead of INSECURE in case when security is disabled
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1511
> URL: https://issues.apache.org/jira/browse/TAP5-1511
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Alexander Gavrilov
> Assignee: Howard M. Lewis Ship
> Fix For: 5.3
>
>
> In current version unless security is enabled RequestSecurityManager#checkPageSecurity always returns LinkSecurity.INSECURE.
> It could be better to return LinkSecurity.SECURE or LinkSecurity.INSECURE depends on request security flag.
> {code:java}
> if (!securityEnabled)
> return request.isSecure() ? LinkSecurity.SECURE : LinkSecurity.INSECURE;
> {code}
> For now even if request to application is come by https tapestry generate http urls for getAbsolueURL call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1511)
RequestSecurityManager.checkPageSecurity() should return request security
instead of INSECURE in case when security is disabled
Posted by "Howard M. Lewis Ship (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1511:
---------------------------------------
Summary: RequestSecurityManager.checkPageSecurity() should return request security instead of INSECURE in case when security is disabled (was: RequestSecurityManager#checkPageSecurity should return request security insed of INSECURE in case when security is disabled)
> RequestSecurityManager.checkPageSecurity() should return request security instead of INSECURE in case when security is disabled
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1511
> URL: https://issues.apache.org/jira/browse/TAP5-1511
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Alexander Gavrilov
> Fix For: 5.3
>
>
> In current version unless security is enabled RequestSecurityManager#checkPageSecurity always returns LinkSecurity.INSECURE.
> It could be better to return LinkSecurity.SECURE or LinkSecurity.INSECURE depends on request security flag.
> {code:java}
> if (!securityEnabled)
> return request.isSecure() ? LinkSecurity.SECURE : LinkSecurity.INSECURE;
> {code}
> For now even if request to application is come by https tapestry generate http urls for getAbsolueURL call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1511)
RequestSecurityManager#checkPageSecurity should return request security
insed of INSECURE in case when security is disabled
Posted by "Alexander Gavrilov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129131#comment-13129131 ]
Alexander Gavrilov commented on TAP5-1511:
------------------------------------------
Https security is not required for our application but must be supported if request comes by https, because we serve pages that can be included into another sites through iframe.
> RequestSecurityManager#checkPageSecurity should return request security insed of INSECURE in case when security is disabled
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1511
> URL: https://issues.apache.org/jira/browse/TAP5-1511
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.5
> Reporter: Alexander Gavrilov
>
> In current version unless security is enabled RequestSecurityManager#checkPageSecurity always returns LinkSecurity.INSECURE.
> It could be better to return LinkSecurity.SECURE or LinkSecurity.INSECURE depends on request security flag.
> {code:java}
> if (!securityEnabled)
> return request.isSecure() ? LinkSecurity.SECURE : LinkSecurity.INSECURE;
> {code}
> For now even if request to application is come by https tapestry generate http urls for getAbsolueURL call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1511)
RequestSecurityManager.checkPageSecurity() should return request security
instead of INSECURE in case when security is disabled
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134415#comment-13134415 ]
Hudson commented on TAP5-1511:
------------------------------
Integrated in tapestry-trunk-freestyle #605 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/605/])
TAP5-1511: RequestSecurityManager.checkPageSecurity() should return request security instead of INSECURE in case when security is disabled
hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1188278
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/RequestSecurityManager.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/RequestSecurityManagerImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/RequestSecurityManagerImplTest.java
> RequestSecurityManager.checkPageSecurity() should return request security instead of INSECURE in case when security is disabled
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1511
> URL: https://issues.apache.org/jira/browse/TAP5-1511
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Alexander Gavrilov
> Assignee: Howard M. Lewis Ship
> Fix For: 5.3
>
>
> In current version unless security is enabled RequestSecurityManager#checkPageSecurity always returns LinkSecurity.INSECURE.
> It could be better to return LinkSecurity.SECURE or LinkSecurity.INSECURE depends on request security flag.
> {code:java}
> if (!securityEnabled)
> return request.isSecure() ? LinkSecurity.SECURE : LinkSecurity.INSECURE;
> {code}
> For now even if request to application is come by https tapestry generate http urls for getAbsolueURL call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1511)
RequestSecurityManager.checkPageSecurity() should return request security
instead of INSECURE in case when security is disabled
Posted by "Howard M. Lewis Ship (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1511:
---------------------------------------
Summary: RequestSecurityManager.checkPageSecurity() should return request security instead of INSECURE in case when security is disabled (was: RequestSecurityManager#checkPageSecurity should return request security insed of INSECURE in case when security is disabled)
> RequestSecurityManager.checkPageSecurity() should return request security instead of INSECURE in case when security is disabled
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1511
> URL: https://issues.apache.org/jira/browse/TAP5-1511
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Alexander Gavrilov
> Fix For: 5.3
>
>
> In current version unless security is enabled RequestSecurityManager#checkPageSecurity always returns LinkSecurity.INSECURE.
> It could be better to return LinkSecurity.SECURE or LinkSecurity.INSECURE depends on request security flag.
> {code:java}
> if (!securityEnabled)
> return request.isSecure() ? LinkSecurity.SECURE : LinkSecurity.INSECURE;
> {code}
> For now even if request to application is come by https tapestry generate http urls for getAbsolueURL call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1511)
RequestSecurityManager#checkPageSecurity should return request security
insed of INSECURE in case when security is disabled
Posted by "Howard M. Lewis Ship (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129100#comment-13129100 ]
Howard M. Lewis Ship commented on TAP5-1511:
--------------------------------------------
Why would security be disabled in a production application? The intent of disabling security is to prevent unwanted http/https handover requests in development.
> RequestSecurityManager#checkPageSecurity should return request security insed of INSECURE in case when security is disabled
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1511
> URL: https://issues.apache.org/jira/browse/TAP5-1511
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.5
> Reporter: Alexander Gavrilov
>
> In current version unless security is enabled RequestSecurityManager#checkPageSecurity always returns LinkSecurity.INSECURE.
> It could be better to return LinkSecurity.SECURE or LinkSecurity.INSECURE depends on request security flag.
> {code:java}
> if (!securityEnabled)
> return request.isSecure() ? LinkSecurity.SECURE : LinkSecurity.INSECURE;
> {code}
> For now even if request to application is come by https tapestry generate http urls for getAbsolueURL call.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira