You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/20 21:57:45 UTC

[GitHub] [arrow] nealrichardson opened a new pull request #7236: ARROW-8703: [R] schema$metadata should be properly typed

nealrichardson opened a new pull request #7236:
URL: https://github.com/apache/arrow/pull/7236


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson commented on pull request #7236: ARROW-8703: [R] schema$metadata should be properly typed

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #7236:
URL: https://github.com/apache/arrow/pull/7236#issuecomment-632169594


   @jorisvandenbossche that part is a little magical. `tab$metadata$foo <- 42` essentially gets the list from `tab$metadata` anonymously, does `that$foo <- 42`, and then assigns `tab$metadata <- that`. So there's only one path to updating at the C++ level, replacing the whole metadata object.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson commented on pull request #7236: ARROW-8703: [R] schema$metadata should be properly typed

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #7236:
URL: https://github.com/apache/arrow/pull/7236#issuecomment-631806382


   @jorisvandenbossche could you give this a quick glance? https://github.com/apache/arrow/pull/7236/files#diff-4f1c8c5db1e5e55eab54a6f88138bfe1R322-R333 is the most concise view of the interface this adds. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #7236: ARROW-8703: [R] schema$metadata should be properly typed

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7236:
URL: https://github.com/apache/arrow/pull/7236#issuecomment-631751315


   https://issues.apache.org/jira/browse/ARROW-8703


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] fsaintjacques closed pull request #7236: ARROW-8703: [R] schema$metadata should be properly typed

Posted by GitBox <gi...@apache.org>.
fsaintjacques closed pull request #7236:
URL: https://github.com/apache/arrow/pull/7236


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorisvandenbossche commented on pull request #7236: ARROW-8703: [R] schema$metadata should be properly typed

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #7236:
URL: https://github.com/apache/arrow/pull/7236#issuecomment-631924558


   That looks good to me. 
   In Python, we don't allow editing the metadata in-place (there are methods to add or update it, but those return a new table / new schema), so in that sense we follow more how it is done on the C++ side, but I don't think it is a problem to update the pointer in place.
   
   One question: if you do like `tab$metadata <- list(test = TRUE)`, I understand in the code how this change is propagated to the actual table, but if you do `tab$metadata$foo <- 42` (which updates the named list), how is that propagated to the metadata on the C++ level?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org