You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by sa...@apache.org on 2012/04/26 13:15:48 UTC
svn commit: r1330778 - /ofbiz/trunk/framework/base/config/test-containers.xml
Author: sascharodekamp
Date: Thu Apr 26 11:15:48 2012
New Revision: 1330778
URL: http://svn.apache.org/viewvc?rev=1330778&view=rev
Log:
Change the RMI and JNDI port in the Test-containers.xml to 1099. Because the jndi servers in jndiservers.xml/jndi.properties are also configured to port 1099. If another port is set in the *-containers.xml the JNDI server could not be reached.
Modified:
ofbiz/trunk/framework/base/config/test-containers.xml
Modified: ofbiz/trunk/framework/base/config/test-containers.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/config/test-containers.xml?rev=1330778&r1=1330777&r2=1330778&view=diff
==============================================================================
--- ofbiz/trunk/framework/base/config/test-containers.xml (original)
+++ ofbiz/trunk/framework/base/config/test-containers.xml Thu Apr 26 11:15:48 2012
@@ -31,14 +31,15 @@ under the License.
<!-- load the naming (JNDI) server -->
<container name="naming-container" class="org.ofbiz.base.container.NamingServiceContainer">
- <property name="port" value="1100"/>
+ <property name="host" value="0.0.0.0"/>
+ <property name="port" value="1099"/>
</container>
<!-- RMI Service Dispatcher -->
<container name="rmi-dispatcher" class="org.ofbiz.service.rmi.RmiServiceContainer">
<property name="bound-name" value="RMIDispatcher"/>
<property name="bound-host" value="127.0.0.1"/>
- <property name="bound-port" value="1100"/>
+ <property name="bound-port" value="1099"/>
<property name="delegator-name" value="test"/>
<property name="client-factory" value="org.ofbiz.service.rmi.socket.ssl.SSLClientSocketFactory"/>
<property name="server-factory" value="org.ofbiz.service.rmi.socket.ssl.SSLServerSocketFactory"/>
Re: svn commit: r1330778 - /ofbiz/trunk/framework/base/config/test-containers.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
Agreed, it's just that it's convenient to have OOTB the test container already set in order to not conflict with an OFBiz instance
running on the same machine. This is already done, and yes we can forget about that, unless someone comes with a genious idea (I
have a feeling that we could do better here, just an intution though)
Jacques
From: "Adrian Crum" <ad...@sandglass-software.com>
> Scott has commented on this and I agree with him: This is NOT an issue we need to solve in the project.
>
> 1. Ports are configurable. They can be configured with PATCHES.
> 2. Anyone running into a port conflict can apply a PATCH to change the port settings.
> 3. Any CI environment, Jenkins or otherwise, can run a script to apply the port configuration patch.
>
> PLEASE PLEASE PLEASE can we stop discussing this?
>
> -Adrian
>
> On 4/29/2012 9:15 AM, Jacques Le Roux wrote:
>> Hi,
>>
>> This, and maybe other dependies, must be taken into account at
>> https://issues.apache.org/jira/browse/OFBIZ-4794
>> "set different ports for testing in a CI environment (e.g. Jenkins)"
>> And
>> https://issues.apache.org/jira/browse/OFBIZ-4763
>> "create and use startup profiles"
>>
>> Jacques
>>
>> From: <sa...@apache.org>
>>> Author: sascharodekamp
>>> Date: Thu Apr 26 11:15:48 2012
>>> New Revision: 1330778
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1330778&view=rev
>>> Log:
>>> Change the RMI and JNDI port in the Test-containers.xml to 1099. Because the jndi servers in jndiservers.xml/jndi.properties are
>>> also configured to port 1099. If another port is set in the *-containers.xml the JNDI server could not be reached.
>>>
>>> Modified:
>>> ofbiz/trunk/framework/base/config/test-containers.xml
>>>
>>> Modified: ofbiz/trunk/framework/base/config/test-containers.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/config/test-containers.xml?rev=1330778&r1=1330777&r2=1330778&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/framework/base/config/test-containers.xml (original)
>>> +++ ofbiz/trunk/framework/base/config/test-containers.xml Thu Apr 26 11:15:48 2012
>>> @@ -31,14 +31,15 @@ under the License.
>>>
>>> <!-- load the naming (JNDI) server -->
>>> <container name="naming-container" class="org.ofbiz.base.container.NamingServiceContainer">
>>> - <property name="port" value="1100"/>
>>> + <property name="host" value="0.0.0.0"/>
>>> + <property name="port" value="1099"/>
>>> </container>
>>>
>>> <!-- RMI Service Dispatcher -->
>>> <container name="rmi-dispatcher" class="org.ofbiz.service.rmi.RmiServiceContainer">
>>> <property name="bound-name" value="RMIDispatcher"/>
>>> <property name="bound-host" value="127.0.0.1"/>
>>> - <property name="bound-port" value="1100"/>
>>> + <property name="bound-port" value="1099"/>
>>> <property name="delegator-name" value="test"/>
>>> <property name="client-factory" value="org.ofbiz.service.rmi.socket.ssl.SSLClientSocketFactory"/>
>>> <property name="server-factory" value="org.ofbiz.service.rmi.socket.ssl.SSLServerSocketFactory"/>
>>>
>>>
Re: svn commit: r1330778 - /ofbiz/trunk/framework/base/config/test-containers.xml
Posted by Adrian Crum <ad...@sandglass-software.com>.
Scott has commented on this and I agree with him: This is NOT an issue
we need to solve in the project.
1. Ports are configurable. They can be configured with PATCHES.
2. Anyone running into a port conflict can apply a PATCH to change the
port settings.
3. Any CI environment, Jenkins or otherwise, can run a script to apply
the port configuration patch.
PLEASE PLEASE PLEASE can we stop discussing this?
-Adrian
On 4/29/2012 9:15 AM, Jacques Le Roux wrote:
> Hi,
>
> This, and maybe other dependies, must be taken into account at
> https://issues.apache.org/jira/browse/OFBIZ-4794
> "set different ports for testing in a CI environment (e.g. Jenkins)"
> And
> https://issues.apache.org/jira/browse/OFBIZ-4763
> "create and use startup profiles"
>
> Jacques
>
> From: <sa...@apache.org>
>> Author: sascharodekamp
>> Date: Thu Apr 26 11:15:48 2012
>> New Revision: 1330778
>>
>> URL: http://svn.apache.org/viewvc?rev=1330778&view=rev
>> Log:
>> Change the RMI and JNDI port in the Test-containers.xml to 1099.
>> Because the jndi servers in jndiservers.xml/jndi.properties are also
>> configured to port 1099. If another port is set in the
>> *-containers.xml the JNDI server could not be reached.
>>
>> Modified:
>> ofbiz/trunk/framework/base/config/test-containers.xml
>>
>> Modified: ofbiz/trunk/framework/base/config/test-containers.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/config/test-containers.xml?rev=1330778&r1=1330777&r2=1330778&view=diff
>> ==============================================================================
>>
>> --- ofbiz/trunk/framework/base/config/test-containers.xml (original)
>> +++ ofbiz/trunk/framework/base/config/test-containers.xml Thu Apr 26
>> 11:15:48 2012
>> @@ -31,14 +31,15 @@ under the License.
>>
>> <!-- load the naming (JNDI) server -->
>> <container name="naming-container"
>> class="org.ofbiz.base.container.NamingServiceContainer">
>> - <property name="port" value="1100"/>
>> + <property name="host" value="0.0.0.0"/>
>> + <property name="port" value="1099"/>
>> </container>
>>
>> <!-- RMI Service Dispatcher -->
>> <container name="rmi-dispatcher"
>> class="org.ofbiz.service.rmi.RmiServiceContainer">
>> <property name="bound-name" value="RMIDispatcher"/>
>> <property name="bound-host" value="127.0.0.1"/>
>> - <property name="bound-port" value="1100"/>
>> + <property name="bound-port" value="1099"/>
>> <property name="delegator-name" value="test"/>
>> <property name="client-factory"
>> value="org.ofbiz.service.rmi.socket.ssl.SSLClientSocketFactory"/>
>> <property name="server-factory"
>> value="org.ofbiz.service.rmi.socket.ssl.SSLServerSocketFactory"/>
>>
>>
Re: svn commit: r1330778 - /ofbiz/trunk/framework/base/config/test-containers.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi,
This, and maybe other dependies, must be taken into account at
https://issues.apache.org/jira/browse/OFBIZ-4794
"set different ports for testing in a CI environment (e.g. Jenkins)"
And
https://issues.apache.org/jira/browse/OFBIZ-4763
"create and use startup profiles"
Jacques
From: <sa...@apache.org>
> Author: sascharodekamp
> Date: Thu Apr 26 11:15:48 2012
> New Revision: 1330778
>
> URL: http://svn.apache.org/viewvc?rev=1330778&view=rev
> Log:
> Change the RMI and JNDI port in the Test-containers.xml to 1099. Because the jndi servers in jndiservers.xml/jndi.properties are
> also configured to port 1099. If another port is set in the *-containers.xml the JNDI server could not be reached.
>
> Modified:
> ofbiz/trunk/framework/base/config/test-containers.xml
>
> Modified: ofbiz/trunk/framework/base/config/test-containers.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/config/test-containers.xml?rev=1330778&r1=1330777&r2=1330778&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/base/config/test-containers.xml (original)
> +++ ofbiz/trunk/framework/base/config/test-containers.xml Thu Apr 26 11:15:48 2012
> @@ -31,14 +31,15 @@ under the License.
>
> <!-- load the naming (JNDI) server -->
> <container name="naming-container" class="org.ofbiz.base.container.NamingServiceContainer">
> - <property name="port" value="1100"/>
> + <property name="host" value="0.0.0.0"/>
> + <property name="port" value="1099"/>
> </container>
>
> <!-- RMI Service Dispatcher -->
> <container name="rmi-dispatcher" class="org.ofbiz.service.rmi.RmiServiceContainer">
> <property name="bound-name" value="RMIDispatcher"/>
> <property name="bound-host" value="127.0.0.1"/>
> - <property name="bound-port" value="1100"/>
> + <property name="bound-port" value="1099"/>
> <property name="delegator-name" value="test"/>
> <property name="client-factory" value="org.ofbiz.service.rmi.socket.ssl.SSLClientSocketFactory"/>
> <property name="server-factory" value="org.ofbiz.service.rmi.socket.ssl.SSLServerSocketFactory"/>
>
>