[GitHub] [streampipes] tenthe commented on a diff in pull request #1064: [#877] add formatting and linting to pipeline-details module

[GitBox <gi...@apache.org>]

tenthe commented on code in PR #1064:
URL: https://github.com/apache/streampipes/pull/1064#discussion_r1064667966


##########
ui/src/app/pipeline-details/components/edit/quickedit.component.html:
##########
@@ -16,52 +16,75 @@
   ~
   -->
 
-<sp-basic-nav-tabs [spNavigationItems]="tabs"
-                   [activeLink]="'quick-edit'"
-                   [showBackLink]="true"
-                   [backLinkTarget]="['pipelines']">
-
+<sp-basic-nav-tabs
+    [spNavigationItems]="tabs"
+    [activeLink]="'sp-quick-edit'"

Review Comment:
   No, this should not be changed.
   This is related to the route and not the component.
   The route is registered in the module (see [1])
   
   [1] https://github.com/apache/streampipes/blob/dev/ui/src/app/pipelines/pipelines.module.ts



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org