You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@struts.apache.org by "lukaszlenart (via GitHub)" <gi...@apache.org> on 2026/02/10 16:04:06 UTC
[PR] fix: remediate private and deprecated API usages for marketplace approval [struts-intellij-plugin]
lukaszlenart opened a new pull request, #42:
URL: https://github.com/apache/struts-intellij-plugin/pull/42
## Summary
This PR remediates private and deprecated IntelliJ Platform API usages identified in the JetBrains Marketplace verification report for plugin version 253.x.
### Critical Fixes (Internal/Scheduled for Removal APIs)
- Replace `IconManager.loadRasterizedIcon()` with `IconLoader.getIcon()` in icon classes
- Replace `WebFacet.getWebRoots(boolean)` with `getWebRoots()` (deprecated boolean param)
- Replace `AnActionButton` with `DumbAwareAction` in toolbar decorator
- Replace `ResourceRegistrar.addStdResource(String,String,Class)` with ClassLoader version
### Deprecated API Fixes
- Replace `IdeFocusManager.doWhenFocusSettlesDown()` with direct `requestFocus()`
- Replace `FilenameIndex.getFilesByName()` with `getVirtualFilesByName()` + `PsiManager.findFile()`
- Replace deprecated `URL(String)` constructor with `URI.create().toURL()`
### Documented Limitations (No Public Replacement Available)
- `GraphBuilder.initialize()` - Internal API, documented with TODO
- `GraphBuilder.queueUpdate()` - Deprecated, documented with TODO
- `JavaClassReferenceProvider.EXTEND_CLASS_NAMES` - Deprecated, documented with TODO
- `FacetConfiguration.readExternal/writeExternal` - Deprecated but part of interface
## Test Plan
- [x] `./gradlew build -x rat` - Build successful
- [x] `./gradlew test -x rat` - All tests pass
- [ ] Run `./gradlew runPluginVerifier` to verify reduced API issues
- [ ] Manual test with `./gradlew runIde`
## Files Changed
| File | Changes |
|------|---------|
| OgnlIcons.java | IconLoader replacement |
| Struts2Icons.java | IconLoader replacement |
| FileReferenceSetHelper.java | WebFacet.getWebRoots() fix |
| FileSetConfigurationTab.java | DumbAwareAction + requestFocus fixes |
| Struts2GraphComponent.java | GraphBuilder TODO documentation |
| Struts2GraphFileEditor.java | GraphBuilder TODO documentation |
| Struts2ResourceProvider.java | ClassLoader-based resource registration |
| Struts2GlobalMacroProvider.java | FilenameIndex replacement |
| HardcodedActionUrlInspection.java | URI.create().toURL() fix |
| ConstantValueClassConverter.java | EXTEND_CLASS_NAMES documentation |
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: remediate private and deprecated API usages for marketplace approval [struts-intellij-plugin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42:
URL: https://github.com/apache/struts-intellij-plugin/pull/42#issuecomment-3878990396
# Qodana for JVM
**It seems all right 👌**
No new problems were found according to the checks applied
💡 Qodana analysis was run in the pull request mode: only the changed files were checked
<details>
<summary>View the detailed Qodana report</summary>
To be able to view the detailed Qodana report, you can either:
- Register at [Qodana Cloud](https://qodana.cloud/) and [configure the action](https://github.com/jetbrains/qodana-action#qodana-cloud)
- Use [GitHub Code Scanning with Qodana](https://github.com/jetbrains/qodana-action#github-code-scanning)
- Host [Qodana report at GitHub Pages](https://github.com/JetBrains/qodana-action/blob/3a8e25f5caad8d8b01c1435f1ef7b19fe8b039a0/README.md#github-pages)
- Inspect and use `qodana.sarif.json` (see [the Qodana SARIF format](https://www.jetbrains.com/help/qodana/qodana-sarif-output.html#Report+structure) for details)
To get `*.log` files or any other Qodana artifacts, run the action with `upload-result` option set to `true`,
so that the action will upload the files as the job artifacts:
```yaml
- name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.3.1
with:
upload-result: true
```
</details>
<details>
<summary>Contact Qodana team</summary>
Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com)
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
</details>
<!-- JetBrains/qodana-action@v2025.3.1 : Qodana for JVM, -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: remediate private and deprecated API usages for marketplace approval [struts-intellij-plugin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42:
URL: https://github.com/apache/struts-intellij-plugin/pull/42#issuecomment-3878992655
<!-- plugin-artifact-comment -->
🔌 **Plugin artifact ready for testing!**
Download from [Actions artifacts](https://github.com/apache/struts-intellij-plugin/actions/runs/21872432281#artifacts)
Artifact: `struts2-253.18970.1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: remediate private and deprecated API usages for marketplace approval [struts-intellij-plugin]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart merged PR #42:
URL: https://github.com/apache/struts-intellij-plugin/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org