You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by ykye <gi...@git.apache.org> on 2015/11/14 13:10:10 UTC
[GitHub] couchdb-fauxton pull request: String edits for Fauxton - 1
GitHub user ykye opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/575
String edits for Fauxton - 1
String edits for Fauxton
BugzID: 55151
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ykye/couchdb-fauxton 55151-string-edits-for-fauxton-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/575.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #575
----
commit bbd1acf5bf1d526caa4d0a43a73fe924a1f412b1
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-13T11:08:26Z
change database string
commit e0fed78c8dfa6f330ef4733bb53c9d819e2cb9a8
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-13T11:27:45Z
change config string
commit 4f3f0ae19069ad6edbc98edca87b03c953b6d429
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-13T11:34:57Z
change replication string
commit 1dc886540e9a4800b53e95c35a38c8a3c9c50652
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-13T11:47:45Z
change auth string
commit 2fadf0645da645a242f0fc89f0be35a45707e45c
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-14T10:03:40Z
change config string
commit c64d39600d5bc9ce88bf478760d4b01fc38aadc0
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-14T10:13:02Z
change compaction string
commit 2c4f4a63b7755a2f07b21709f52f55c9f7e1f342
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-14T11:46:40Z
change permission string
commit 4a1b935c60575dfc54b17ddccbf8b2155f43d409
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-14T12:01:52Z
change 'Changes' string
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#issuecomment-156694629
@ykye why closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Improve the strings
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#discussion_r45573716
--- Diff: app/addons/auth/components.react.jsx ---
@@ -239,9 +238,6 @@ define([
<input id="password" type="password" name="password" placeholder= "Password" size="24"
onChange={this.onChangePassword} />
<p>
- Non-admin users have read and write access to all databases, which
- are controlled by validation functions. CouchDB can be configured to block all
- access to anonymous users.
--- End diff --
Technically, to block anonymous users you need to fix admin party (aka create admin) and set [require_valid_user](http://docs.couchdb.org/en/1.6.1/config/auth.html#couch_httpd_auth/require_valid_user) as `true`, so everyone have to auth to send any request to CouchDB.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#discussion_r44907802
--- Diff: app/addons/auth/components.react.jsx ---
@@ -154,12 +153,12 @@ define([
<input id="password" type="password" ref="password" name="password" placeholder="Password"
size="24" onChange={this.onChangePassword} value={this.state.password} />
<br />
- <input id="password-confirm" type="password" name="password_confirm" placeholder= "Verify Password"
+ <input id="password-confirm" type="password" name="password_confirm" placeholder= "Password confirmation"
--- End diff --
`placeholder= "Password confirmation"`
one whitespace that does not belong there
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Improve the strings
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#discussion_r45475052
--- Diff: app/addons/auth/components.react.jsx ---
@@ -239,9 +238,6 @@ define([
<input id="password" type="password" name="password" placeholder= "Password" size="24"
onChange={this.onChangePassword} />
<p>
- Non-admin users have read and write access to all databases, which
- are controlled by validation functions. CouchDB can be configured to block all
- access to anonymous users.
--- End diff --
Hello. :) I didn't mean to delete the paragraph. I meant the new wording needs some improvements.
What was wrong with this original wording? I like it.
As Kxepal mentioned, it might be helpful to point the user to where/how they can protect their database(s). Perhaps a helpful link in a circle-question-mark-symbol, to the correct place in the docs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by ykye <gi...@git.apache.org>.
GitHub user ykye reopened a pull request:
https://github.com/apache/couchdb-fauxton/pull/575
String edits for Fauxton
String edits for Fauxton
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ykye/couchdb-fauxton 55151-string-edits-for-fauxton-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/575.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #575
----
commit bbd1acf5bf1d526caa4d0a43a73fe924a1f412b1
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-13T11:08:26Z
change database string
commit e0fed78c8dfa6f330ef4733bb53c9d819e2cb9a8
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-13T11:27:45Z
change config string
commit 4f3f0ae19069ad6edbc98edca87b03c953b6d429
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-13T11:34:57Z
change replication string
commit 1dc886540e9a4800b53e95c35a38c8a3c9c50652
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-13T11:47:45Z
change auth string
commit 2fadf0645da645a242f0fc89f0be35a45707e45c
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-14T10:03:40Z
change config string
commit c64d39600d5bc9ce88bf478760d4b01fc38aadc0
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-14T10:13:02Z
change compaction string
commit 2c4f4a63b7755a2f07b21709f52f55c9f7e1f342
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-14T11:46:40Z
change permission string
commit 4a1b935c60575dfc54b17ddccbf8b2155f43d409
Author: Kang Ye <yk...@cn.ibm.com>
Date: 2015-11-14T12:01:52Z
change 'Changes' string
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#discussion_r44907481
--- Diff: app/addons/config/routes.js ---
@@ -67,7 +67,7 @@ function (app, FauxtonAPI, Config, Views, CORSComponents, CORSActions, ClusterAc
this.sidebar = this.setView('#sidebar-content', new Views.Tabs({
sidebarItems: [
{
- title: 'Main config',
+ title: 'config.js File',
--- End diff --
config.js File?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#issuecomment-156784655
Also, I'm not sure if same rules applies to Fauxton ,but AFAIK you need to create PR from Cloudant fork and not use BugzID, but CouchDB JIRA issue number. Or both at least. Ask your team mates for the details, that could be important.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #575: Improve the strings
Posted by Humbedooh <gi...@git.apache.org>.
Github user Humbedooh closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/575
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#discussion_r44907599
--- Diff: app/addons/permissions/components.react.jsx ---
@@ -123,39 +123,73 @@ function (app, FauxtonAPI, React, Components, Stores, Actions) {
this.setState({newRole: e.target.value});
},
+ getAccountBlurb: function () {
+ var blurb = '';
+ if (this.props.section === 'admins') {
+ blurb = 'Grant database ADMIN privileges to the following user accounts:';
+ } else {
+ blurb = 'Grant database member privileges to user accounts with the following roles:';
+ }
+ return (
+ <header>
+ <h4 className="capitalize">{this.props.section} Accounts</h4>
+ <p>{blurb}</p>
+ </header>
+ );
+ },
+
+ getRoleBlurb: function () {
+ var blurb = '';
+ if (this.props.section === 'admins') {
+ blurb = 'Grant database ADMIN privileges to user accounts with the following roles:';
+ } else {
+ blurb = 'Grant database member privileges to user accounts with the following roles:';
+ }
+ return (
--- End diff --
you can use omit the else case in both functions:
```js
var blurb = 'Grant database member privileges to user accounts with the following roles:';
if (this.props.section === 'admins') {
blurb = 'Grant database ADMIN privileges to user accounts with the following roles:';
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by ykye <gi...@git.apache.org>.
Github user ykye commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#issuecomment-156785036
@kxepal Thank you kxepal. I will ask my team mates later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#issuecomment-156784602
@ykye Congrats with the first PR! (:
Don't worry about: automatically merged means that there are no merge conflicts that could involve people to resolve them and you can easily press merge button. However, we don't have such, so all the PR's merged manually with care and after review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Improve the strings
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#discussion_r45270016
--- Diff: app/addons/auth/components.react.jsx ---
@@ -219,17 +218,17 @@ define([
render: function () {
return (
<div className="auth-page">
- <h3>Create Admins</h3>
+ <h3>Create User Accounts with ADMIN Privileges</h3>
<p>
- Before a server admin is configured, all clients have admin privileges. This is fine when
- HTTP access is restricted to trusted users. <strong>If end-users will be accessing this
- CouchDB, you must create an admin account to prevent accidental (or malicious) data
- loss.</strong>
+ Before an admin user account is created for this CouchDB server instance,
+ all clients have ADMIN privileges. <strong>If clients are not trusted users,
+ you must create an admin account to prevent accidental or malicious data loss.</strong>
</p>
<p>
- Server admins can create and destroy databases, install and update _design documents, run
- the test suite, and edit all aspects of CouchDB configuration.
+ Users with ADMIN privileges can create, modify, and delete databases and design documents;
+ run the test suite; and modify the CouchDB configuration. Users without ADMIN privileges
+ have read/write access to all databases. CouchDB can be configured to block access by anonymous users.
--- End diff --
"CouchDB can be configured to block access by anonymous users." Can you rewrite this sentence?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#discussion_r44907740
--- Diff: app/addons/permissions/components.react.jsx ---
@@ -123,39 +123,73 @@ function (app, FauxtonAPI, React, Components, Stores, Actions) {
this.setState({newRole: e.target.value});
},
+ getAccountBlurb: function () {
+ var blurb = '';
+ if (this.props.section === 'admins') {
+ blurb = 'Grant database ADMIN privileges to the following user accounts:';
+ } else {
+ blurb = 'Grant database member privileges to user accounts with the following roles:';
+ }
+ return (
+ <header>
+ <h4 className="capitalize">{this.props.section} Accounts</h4>
+ <p>{blurb}</p>
+ </header>
+ );
+ },
+
+ getRoleBlurb: function () {
+ var blurb = '';
+ if (this.props.section === 'admins') {
+ blurb = 'Grant database ADMIN privileges to user accounts with the following roles:';
+ } else {
+ blurb = 'Grant database member privileges to user accounts with the following roles:';
+ }
+ return (
+ <header>
+ <h4 className="capitalize">{this.props.section} Roles</h4>
+ <p>{blurb}</p>
+ </header>
+ );
+ },
+
+ getPageHeader: function () {
+ if (this.props.section === 'admins') {
+ return (
+ <header className="page-header">
+ <h3>{this.props.title}</h3>
+ <p className="help">
+ {this.getHelp()}
+ <a className="help-link" data-bypass="true" href={getDocUrl('DB_PERMISSION')} target="_blank">
+ <i className="icon-question-sign"></i>
+ </a>
+ </p>
+ </header>
+ );
+ } else {
+ return '';
--- End diff --
you can use an early return instead.
please also return `null` instead of an empty string
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#discussion_r44913183
--- Diff: app/addons/config/routes.js ---
@@ -67,7 +67,7 @@ function (app, FauxtonAPI, Config, Views, CORSComponents, CORSActions, ClusterAc
this.sidebar = this.setView('#sidebar-content', new Views.Tabs({
sidebarItems: [
{
- title: 'Main config',
+ title: 'config.js File',
--- End diff --
I think instead of `Main config` maybe something like General. Its actually all the config but CORS.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Improve the strings
Posted by ykye <gi...@git.apache.org>.
Github user ykye commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#discussion_r45573598
--- Diff: app/addons/auth/components.react.jsx ---
@@ -239,9 +238,6 @@ define([
<input id="password" type="password" name="password" placeholder= "Password" size="24"
onChange={this.onChangePassword} />
<p>
- Non-admin users have read and write access to all databases, which
- are controlled by validation functions. CouchDB can be configured to block all
- access to anonymous users.
--- End diff --
I wanted to change the last sentence to "CouchDB can be configured to block the access of anonymous users." and add the link "http://docs.couchdb.org/en/1.6.1/config/auth.html" to it, but I found that it’s not necessarily related to ADMIN privileges, so I deleted the last sentence.
https://wiki.apache.org/couchdb/Security_Features_Overview
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#discussion_r44908356
--- Diff: app/addons/config/routes.js ---
@@ -67,7 +67,7 @@ function (app, FauxtonAPI, Config, Views, CORSComponents, CORSActions, ClusterAc
this.sidebar = this.setView('#sidebar-content', new Views.Tabs({
sidebarItems: [
{
- title: 'Main config',
+ title: 'config.js File',
--- End diff --
Speaking from backend side, there are no Main config or 'config.js'. Users knowns that all configs are stored in INI files, so if you tell them about some config.js someone mind gonna blow.
"Main config" name isn't good here as well since as you can see, there is CORS menu item. Which means, that here we actually see some configuration groups, not some special configuration From this point "General" instead of "Main config" would be more sane replacement. Or "All configuration" - also good, especially in mid-term perspective (imagine that there will be more groups like Auth, Compaction, Databases, Admins etc).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by ykye <gi...@git.apache.org>.
Github user ykye commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#issuecomment-156783768
@kxepal This is my first time to create a pull request for Fauxton. I created this PR, but I found it can be automatically merged. I wasn't very sure if the process of this PR is right. I asked @benkeen, he told me this is natural. So reopen this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by ykye <gi...@git.apache.org>.
Github user ykye closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/575
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Improve the strings
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#discussion_r45270468
--- Diff: app/addons/auth/components.react.jsx ---
@@ -219,17 +218,17 @@ define([
render: function () {
return (
<div className="auth-page">
- <h3>Create Admins</h3>
+ <h3>Create User Accounts with ADMIN Privileges</h3>
<p>
- Before a server admin is configured, all clients have admin privileges. This is fine when
- HTTP access is restricted to trusted users. <strong>If end-users will be accessing this
- CouchDB, you must create an admin account to prevent accidental (or malicious) data
- loss.</strong>
+ Before an admin user account is created for this CouchDB server instance,
+ all clients have ADMIN privileges. <strong>If clients are not trusted users,
+ you must create an admin account to prevent accidental or malicious data loss.</strong>
</p>
<p>
- Server admins can create and destroy databases, install and update _design documents, run
- the test suite, and edit all aspects of CouchDB configuration.
+ Users with ADMIN privileges can create, modify, and delete databases and design documents;
+ run the test suite; and modify the CouchDB configuration. Users without ADMIN privileges
+ have read/write access to all databases. CouchDB can be configured to block access by anonymous users.
--- End diff --
I think such sentence requires a link to somewhere to answer on upcoming question: "That's great! How?".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by ykye <gi...@git.apache.org>.
Github user ykye commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#issuecomment-156783784
@benkeen Please help have a look at.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by ykye <gi...@git.apache.org>.
Github user ykye commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#discussion_r44907808
--- Diff: app/addons/config/routes.js ---
@@ -67,7 +67,7 @@ function (app, FauxtonAPI, Config, Views, CORSComponents, CORSActions, ClusterAc
this.sidebar = this.setView('#sidebar-content', new Views.Tabs({
sidebarItems: [
{
- title: 'Main config',
+ title: 'config.js File',
--- End diff --
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #575: Improve the strings
Posted by Humbedooh <gi...@git.apache.org>.
Github user Humbedooh commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/575
Abandoned issue. Closing here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: String edits for Fauxton
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/575#issuecomment-156982718
looks good, i left a few comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---